Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

.Net: Azure AI Inference Connector - Project + References #7961

Merged
merged 3 commits into from
Aug 7, 2024
Merged

.Net: Azure AI Inference Connector - Project + References #7961

merged 3 commits into from
Aug 7, 2024

Conversation

RogerBarreto
Copy link
Member

@RogerBarreto RogerBarreto commented Aug 7, 2024 •
edited
Loading

Motivation and Context

@RogerBarreto RogerBarreto requested a review from a team as a code owner August 7, 2024 14:00
@RogerBarreto RogerBarreto added PR: in progress Under development and/or addressing feedback .NET Issue or Pull requests regarding .NET code ai connector Anything related to AI connectors sk team issue A tag to denote issues that where created by the Semantic Kernel team (i.e., not the community) labels Aug 7, 2024
@RogerBarreto RogerBarreto self-assigned this Aug 7, 2024
@markwallace-microsoft markwallace-microsoft added the kernel Issues or pull requests impacting the core kernel label Aug 7, 2024
@RogerBarreto
NU5104
a3eb1b7 
Add missing NU5104 exemption
SergeyMenshykh
SergeyMenshykh approved these changes Aug 7, 2024
View reviewed changes
dotnet/SK-dotnet.sln
{E34695C3-B652-478C-BA7B-466249F5C7E1}.Release|Any CPU.Build.0 = Release|Any CPU
{572EDF3C-D3E2-4AEA-8039-93D37AC3BED2}.Debug|Any CPU.ActiveCfg = Debug|Any CPU
{572EDF3C-D3E2-4AEA-8039-93D37AC3BED2}.Debug|Any CPU.Build.0 = Debug|Any CPU
{572EDF3C-D3E2-4AEA-8039-93D37AC3BED2}.Publish|Any CPU.ActiveCfg = Debug|Any CPU
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should not it be Publish|Any CPU instead of Debug|Any CPU here and above?

dotnet/src/Connectors/Connectors.AzureAIInference/Connectors.AzureAIInference.csproj Outdated

<PropertyGroup>
<!-- NuGet Package Settings -->
<Title>Semantic Kernel - Azure AI Inference connector</Title>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Semantic Kernel - Azure AI Inference connectors?

@RogerBarreto RogerBarreto merged commit 8d47e21 into microsoft:feature-connectors-azureaiinference Aug 7, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SergeyMenshykh SergeyMenshykh SergeyMenshykh approved these changes

Assignees

@RogerBarreto RogerBarreto

Labels
ai connector Anything related to AI connectors kernel Issues or pull requests impacting the core kernel .NET Issue or Pull requests regarding .NET code PR: in progress Under development and/or addressing feedback sk team issue A tag to denote issues that where created by the Semantic Kernel team (i.e., not the community)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@RogerBarreto @SergeyMenshykh @markwallace-microsoft