Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.Net: Enable bidirectional adapters between SK and Microsoft.Extensions.AI interfaces #9183

Closed
wants to merge 1 commit into from

Conversation

stephentoub
Copy link
Member

@stephentoub stephentoub commented Oct 9, 2024

This is part 1 of replatforming Semantic Kernel on top of Microsoft.Extensions.AI, making it possible to use IChatCompletionService instances as IChatClient instances, and vice versa, and similarly for IEmbeddingGenerationService and IEmbeddingGenerator. The next step after this is refactoring the connectors to use M.E.AI internally where relevant.

I still need to add tests and fix whatever bugs they find.

@stephentoub stephentoub requested a review from a team as a code owner October 9, 2024 18:37
@markwallace-microsoft markwallace-microsoft added .NET Issue or Pull requests regarding .NET code kernel.core labels Oct 9, 2024
@github-actions github-actions bot changed the title Enable bidirectional adapters between SK interfaces and Microsoft.Extensions.AI .Net: Enable bidirectional adapters between SK interfaces and Microsoft.Extensions.AI Oct 9, 2024
@stephentoub stephentoub marked this pull request as draft October 9, 2024 18:41
@markwallace-microsoft markwallace-microsoft added the kernel Issues or pull requests impacting the core kernel label Oct 9, 2024
@RogerBarreto RogerBarreto changed the base branch from main to feature-msextensions-ai October 19, 2024 12:50
@markwallace-microsoft markwallace-microsoft added python Pull requests for the Python Semantic Kernel documentation memory labels Oct 26, 2024
@github-actions github-actions bot changed the title .Net: Enable bidirectional adapters between SK interfaces and Microsoft.Extensions.AI Python: .Net: Enable bidirectional adapters between SK interfaces and Microsoft.Extensions.AI Oct 26, 2024
@stephentoub stephentoub changed the base branch from feature-msextensions-ai to main October 26, 2024 21:05
@stephentoub stephentoub marked this pull request as ready for review October 26, 2024 21:06
@stephentoub stephentoub changed the title Python: .Net: Enable bidirectional adapters between SK interfaces and Microsoft.Extensions.AI .Net: Enable bidirectional adapters between SK interfaces and Microsoft.Extensions.AI Oct 26, 2024
@stephentoub stephentoub changed the title .Net: Enable bidirectional adapters between SK interfaces and Microsoft.Extensions.AI .Net: Enable bidirectional adapters between SK and Microsoft.Extensions.AI interfaces Oct 26, 2024
@stephentoub stephentoub removed python Pull requests for the Python Semantic Kernel memory labels Oct 26, 2024
@markwallace-microsoft
Copy link
Member

Python Unit Test Overview

Tests Skipped Failures Errors Time
2767 4 💤 0 ❌ 0 🔥 1m 7s ⏱️

@stephentoub stephentoub deleted the meaiadapters branch October 26, 2024 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kernel.core kernel Issues or pull requests impacting the core kernel .NET Issue or Pull requests regarding .NET code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants