-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Python: Azure Cosmos DB NoSQL Vector Store & Collection implementation #9296
Merged
eavanvalkenburg
merged 35 commits into
microsoft:main
from
TaoChenOSU:taochen/python-azure-cosmos-db-nosql-vector-collection-impl
Nov 12, 2024
Merged
Python: Azure Cosmos DB NoSQL Vector Store & Collection implementation #9296
eavanvalkenburg
merged 35 commits into
microsoft:main
from
TaoChenOSU:taochen/python-azure-cosmos-db-nosql-vector-collection-impl
Nov 12, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TaoChenOSU
added
PR: in progress
Under development and/or addressing feedback
python
Pull requests for the Python Semantic Kernel
labels
Oct 16, 2024
github-actions
bot
changed the title
Azure Cosmos DB NoSQL Vector Store & Collection implementation
Python: Azure Cosmos DB NoSQL Vector Store & Collection implementation
Oct 16, 2024
8 tasks
TaoChenOSU
removed
the
PR: in progress
Under development and/or addressing feedback
label
Oct 28, 2024
dmytrostruk
reviewed
Oct 29, 2024
python/semantic_kernel/connectors/memory/azure_cosmosdb_no_sql/azure_cosmos_db_no_sql_base.py
Outdated
Show resolved
Hide resolved
...semantic_kernel/connectors/memory/azure_cosmosdb_no_sql/azure_cosmos_db_no_sql_collection.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
couple of small comments
...semantic_kernel/connectors/memory/azure_cosmosdb_no_sql/azure_cosmos_db_no_sql_collection.py
Outdated
Show resolved
Hide resolved
python/semantic_kernel/connectors/memory/azure_cosmosdb_no_sql/utils.py
Outdated
Show resolved
Hide resolved
python/semantic_kernel/connectors/memory/azure_cosmosdb_no_sql/azure_cosmos_db_no_sql_base.py
Outdated
Show resolved
Hide resolved
TaoChenOSU
commented
Nov 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
couple of minor comments, but looking good, let's discuss some of the things directly
python/semantic_kernel/connectors/memory/azure_cosmos_db/azure_cosmos_db_no_sql_base.py
Show resolved
Hide resolved
python/semantic_kernel/connectors/memory/azure_cosmos_db/azure_cosmos_db_no_sql_base.py
Outdated
Show resolved
Hide resolved
python/semantic_kernel/connectors/memory/azure_cosmos_db/azure_cosmos_db_no_sql_base.py
Outdated
Show resolved
Hide resolved
...emantic_kernel/connectors/memory/azure_cosmosdb_no_sql/azure_cosmosdb_no_sql_memory_store.py
Outdated
Show resolved
Hide resolved
python/semantic_kernel/connectors/memory/azure_cosmos_db/azure_cosmos_db_no_sql_base.py
Show resolved
Hide resolved
python/semantic_kernel/connectors/memory/azure_cosmos_db/azure_cosmos_db_no_sql_store.py
Show resolved
Hide resolved
eavanvalkenburg
approved these changes
Nov 12, 2024
python/semantic_kernel/connectors/memory/azure_cosmos_db/azure_cosmos_db_no_sql_collection.py
Show resolved
Hide resolved
eavanvalkenburg
approved these changes
Nov 12, 2024
eavanvalkenburg
approved these changes
Nov 12, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Nov 12, 2024
eavanvalkenburg
approved these changes
Nov 12, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Nov 12, 2024
Bryan-Roe
pushed a commit
to Bryan-Roe-ai/semantic-kernel
that referenced
this pull request
Dec 6, 2024
microsoft#9296) ### Motivation and Context <!-- Thank you for your contribution to the semantic-kernel repo! Please help reviewers and future users, providing the following information: 1. Why is this change required? 2. What problem does it solve? 3. What scenario does it contribute to? 4. If it fixes an open issue, please link to the issue here. --> We are implementing the Azure Cosmos DB NoSQL vector store and vector collection. ### Description Azure Cosmos DB NoSQL vector store & collection implementation. <!-- Describe your changes, the overall approach, the underlying design. These notes will help understanding how your code works. Thanks! --> ### Contribution Checklist <!-- Before submitting this PR, please make sure: --> - [x] The code builds clean without any errors or warnings - [x] The PR follows the [SK Contribution Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md) and the [pre-submission formatting script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts) raises no violations - [x] All unit tests pass, and I have added new tests where possible - [x] I didn't break anyone 😄 --------- Co-authored-by: Eduard van Valkenburg <eavanvalkenburg@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
We are implementing the Azure Cosmos DB NoSQL vector store and vector collection.
Description
Azure Cosmos DB NoSQL vector store & collection implementation.
Contribution Checklist