-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Python: fix mypy pre-commit setup, mypy fixes #9498
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markwallace-microsoft
added
python
Pull requests for the Python Semantic Kernel
memory
labels
Nov 1, 2024
Are most of this PR just reformatting? |
eavanvalkenburg
changed the title
Python: added py3.13 unit tests for all oss
Python: add experimental py3.13 unit tests, fix mypy pre-commit setup, mypy fixes
Nov 4, 2024
moonbox3
reviewed
Nov 4, 2024
moonbox3
approved these changes
Nov 4, 2024
eavanvalkenburg
force-pushed
the
cicd_updates
branch
from
November 6, 2024 09:45
606a735
to
ea7e8e7
Compare
alliscode
approved these changes
Nov 6, 2024
eavanvalkenburg
force-pushed
the
cicd_updates
branch
from
November 6, 2024 16:11
d40a06a
to
9249179
Compare
@eavanvalkenburg can we please fix these unit test errors so we can get all of this into main? Since mypy isn't running properly as part of the GH actions pre-commit, it's hurting things a bit. |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Nov 7, 2024
eavanvalkenburg
had a problem deploying
to
integration
November 7, 2024 10:20 — with
GitHub Actions
Failure
eavanvalkenburg
had a problem deploying
to
integration
November 7, 2024 10:29 — with
GitHub Actions
Failure
eavanvalkenburg
had a problem deploying
to
integration
November 7, 2024 10:33 — with
GitHub Actions
Failure
eavanvalkenburg
had a problem deploying
to
integration
November 7, 2024 10:42 — with
GitHub Actions
Failure
eavanvalkenburg
had a problem deploying
to
integration
November 7, 2024 11:01 — with
GitHub Actions
Failure
eavanvalkenburg
had a problem deploying
to
integration
November 7, 2024 11:09 — with
GitHub Actions
Failure
eavanvalkenburg
had a problem deploying
to
integration
November 7, 2024 11:11 — with
GitHub Actions
Failure
eavanvalkenburg
had a problem deploying
to
integration
November 7, 2024 11:14 — with
GitHub Actions
Failure
eavanvalkenburg
had a problem deploying
to
integration
November 7, 2024 11:20 — with
GitHub Actions
Failure
eavanvalkenburg
had a problem deploying
to
integration
November 7, 2024 11:20 — with
GitHub Actions
Failure
markwallace-microsoft
approved these changes
Nov 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Fixes the mypy pre-commit job, and subsequent fixes from there.
Moved all python tests to use the uv setup task instead of manual cache, python install and uv install.
Description
Contribution Checklist