Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.Net: Remove experimental attribute from the new function calling model classes #9524

Conversation

SergeyMenshykh
Copy link
Member

Removes the Experimental attribute from the new function-calling model classes and function call content classes as part of their graduation.

Corresponding tasks:

…odel classes and funciton call content classes.
@SergeyMenshykh SergeyMenshykh requested a review from a team as a code owner November 4, 2024 18:45
@SergeyMenshykh SergeyMenshykh self-assigned this Nov 4, 2024
@markwallace-microsoft markwallace-microsoft added .NET Issue or Pull requests regarding .NET code kernel.core labels Nov 4, 2024
@stephentoub
Copy link
Member

These are still only supported by the OpenAI connector, right? They're ignored by the Google one, the Mistral one, etc.?

@SergeyMenshykh
Copy link
Member Author

These are still only supported by the OpenAI connector, right? They're ignored by the Google one, the Mistral one, etc.?

Yes, right, only the {Azure}OpenAI connectors use them.

@stephentoub
Copy link
Member

These are still only supported by the OpenAI connector, right? They're ignored by the Google one, the Mistral one, etc.?

Yes, right, only the {Azure}OpenAI connectors use them.

And that will be fixed soon? Feels strange to say these are fully supported but then only have one of the built-in connectors support them.

@SergeyMenshykh
Copy link
Member Author

SergeyMenshykh commented Nov 4, 2024

These are still only supported by the OpenAI connector, right? They're ignored by the Google one, the Mistral one, etc.?

Yes, right, only the {Azure}OpenAI connectors use them.

And that will be fixed soon? Feels strange to say these are fully supported but then only have one of the built-in connectors support them.

We are graduating function-calling model classes and function-call content classes. The former are used by the {Azure}OpenAI connectors, and @RogerBarret0 was successfully able to use them to add function calling to the Ollama connect before the decision was made to go with OllamaSharp and the IChatClient implementation. The latter classes are used by {Azure}OpenAI and MistralAI connectors + Ollama try. Therefore, we believe they are in good shape for graduation.

Regarding adding function-calling support to the other connectors, as far as I understand, support will be added eventually when the connectors are prioritized, most likely after the Ignite event.
CC: @RogerBarret0, @markwallace-microsoft

@SergeyMenshykh SergeyMenshykh added this pull request to the merge queue Nov 11, 2024
Merged via the queue into microsoft:main with commit 4a16849 Nov 11, 2024
15 checks passed
@SergeyMenshykh SergeyMenshykh deleted the remove-experimental-attribute-from-function-calling-model-classes branch November 11, 2024 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kernel.core .NET Issue or Pull requests regarding .NET code
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants