.Net Processes - Support Complex Type Serialization for Dapr Events and Messages #9525
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crickman
added
PR: in progress
markwallace-microsoft
added
the
kernel
esttenorio
reviewed
Nov 5, 2024
dotnet/src/Experimental/Process.Runtime.Dapr/Serialization/KernelProcessEventSerializer.cs
Outdated
Show resolved
Hide resolved
alliscode
reviewed
Nov 5, 2024
dotnet/src/Experimental/Process.Runtime.Dapr/Process.Runtime.Dapr.csproj
Outdated
Show resolved
Hide resolved
alliscode
approved these changes
Nov 5, 2024
esttenorio
approved these changes
Nov 5, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
…oft/semantic-kernel into process-knowntype-upgrade
alliscode
approved these changes
Nov 5, 2024
4 tasks
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 7, 2024
### Motivation and Context <!-- Thank you for your contribution to the semantic-kernel repo! Please help reviewers and future users, providing the following information: 1. Why is this change required? 2. What problem does it solve? 3. What scenario does it contribute to? 4. If it fixes an open issue, please link to the issue here. --> Updated ability to serialize complex types here: #9525 ...but missed the remoting boundary for invoke the process. This change addresses this final gap without altering external patterns. ### Description <!-- Describe your changes, the overall approach, the underlying design. These notes will help understanding how your code works. Thanks! --> Convert event to JSON when invoking `ProcessActor` from `DaprKernelProcessContext` ### Contribution Checklist <!-- Before submitting this PR, please make sure: --> - [X] The code builds clean without any errors or warnings - [X] The PR follows the [SK Contribution Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md) and the [pre-submission formatting script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts) raises no violations - [X] All unit tests pass, and I have added new tests where possible - [X] I didn't break anyone 😄
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
DAPR events and messages result in runtime failure when contain anything other than the supported primitive types:
https://docs.dapr.io/developing-applications/sdks/dotnet/dotnet-actors/dotnet-actors-serialization/#supported-primitive-types
This means arrays, lists, and objects are not currently able to be emitted by steps.
Description
Translating
ProcessMessage,ProcessEvent, andKernelProcessMessageinto JSON strings prior to data-contract serialization. As part of this, any relevant type information is included in the json payload.On deserialization, the type information is utilized to convert any
JsonElementdata values to the expected type.Notes:
DataContractwhere not needed (and tests)varwith explicit types for my own clarity...and left them for posterity.Contribution Checklist