Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

.Net Agents - Add incomplete status to termination check for OpenAIAssistantAgent #9740

Merged
merged 5 commits into from
Nov 18, 2024
Merged

.Net Agents - Add incomplete status to termination check for OpenAIAssistantAgent #9740

merged 5 commits into from
Nov 18, 2024

Conversation

crickman
Copy link
Contributor

Motivation and Context

Fixes: #9729
Fixes: #9672

Include incomplete run status in termination check

Description

The run-status incomplete was added in the V2 API and indicates the run has failed due to a status check, such as content filter or token usage.

Contribution Checklist

@crickman crickman added bug Something isn't working PR: ready for review All feedback addressed, ready for reviews .NET Issue or Pull requests regarding .NET code experimental Associated with an experimental feature agents labels Nov 18, 2024
@crickman crickman self-assigned this Nov 18, 2024
@crickman crickman requested a review from a team as a code owner November 18, 2024 19:37
@github-actions github-actions bot changed the title Fixed .Net: Fixed Nov 18, 2024
@crickman crickman changed the title .Net: Fixed .Net Agents - Add incomplete status to termination check for OpenAIAssistantAgent Nov 18, 2024
@markwallace-microsoft markwallace-microsoft added the kernel Issues or pull requests impacting the core kernel label Nov 18, 2024
@crickman crickman requested a review from TaoChenOSU November 18, 2024 22:05
@crickman crickman added this pull request to the merge queue Nov 18, 2024
Merged via the queue into main with commit e640bd3 Nov 18, 2024
15 checks passed
@crickman crickman deleted the fix-assistant-termination-incomplete branch November 18, 2024 22:41
@crickman crickman removed kernel Issues or pull requests impacting the core kernel PR: ready for review All feedback addressed, ready for reviews labels Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TaoChenOSU TaoChenOSU TaoChenOSU approved these changes

@esttenorio esttenorio esttenorio approved these changes

@alliscode alliscode Awaiting requested review from alliscode

@moonbox3 moonbox3 Awaiting requested review from moonbox3

Assignees

@crickman crickman

Labels
agents bug Something isn't working experimental Associated with an experimental feature .NET Issue or Pull requests regarding .NET code
Projects
Semantic Kernel
Archived in project
Milestone
No milestone
4 participants
@crickman @esttenorio @TaoChenOSU @markwallace-microsoft