Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ManagedIdentityClientId parameter to BackupRestore APIs #134

Merged
merged 2 commits into from
Jul 29, 2024
Merged

Add ManagedIdentityClientId parameter to BackupRestore APIs #134

merged 2 commits into from
Jul 29, 2024

Conversation

olegsych
Copy link
Member

No description provided.

@olegsych olegsych requested a review from jeffj6123 July 25, 2024 21:53
@olegsych olegsych requested a review from gobradovic-MSFT July 25, 2024 22:04
jeffj6123
jeffj6123 approved these changes Jul 26, 2024
View reviewed changes
Copy link
Member

@jeffj6123 jeffj6123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

id say to change it to be the confirm lifecycle verb.

@olegsych olegsych force-pushed the user/olegsych/ManagedIdentityClientId branch from 3d9f0e0 to ed62b50 Compare July 26, 2024 18:07
@olegsych olegsych requested a review from jeffj6123 July 26, 2024 18:15
@olegsych olegsych merged commit ba4fd7a into develop Jul 29, 2024
2 checks passed
@olegsych olegsych deleted the user/olegsych/ManagedIdentityClientId branch July 29, 2024 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeffj6123 jeffj6123 jeffj6123 approved these changes

@gobradovic-MSFT gobradovic-MSFT Awaiting requested review from gobradovic-MSFT

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@olegsych @jeffj6123