Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make up for the lack of intrinsic headers in Open Enclave #195

Merged
merged 1 commit into from
May 21, 2020

Conversation

achamayou
Copy link
Member

@achamayou achamayou commented May 21, 2020

Fix the main remaining problem that prevents building oesnmalloc with -nostdinc. There's still a issue with the order in which headers are copied in the OE build but that's nothing to do with snmalloc.

Paging @anakrish because I can't work how to add him to Reviewers for some reason.

It is probably worth noting that this can be removed if/when
a subset of openenclave/openenclave#1766 is implemented in OE. That's been open for over a year though, so I would still like to have this change considered.

@achamayou achamayou requested a review from mjp41 May 21, 2020 13:46
Copy link
Member

@mjp41 mjp41 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@achamayou
Copy link
Member Author

I'm not quite sure how this happened or why:

##[error]Bash exited with code '128'.
##[error]Bash wrote one or more lines to the standard error stream.
##[error]fatal: bad object 6b4c75a659ce6f15ef32a2ec7661af57aceb3664

@achamayou
Copy link
Member Author

/azp run

@azure-pipelines
Copy link

No pipelines are associated with this pull request.

@mjp41 mjp41 merged commit 8dad07f into microsoft:master May 21, 2020
@anakrish
Copy link
Contributor

Thanks for doing this @achamayou

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants