Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix clang-format lookup to do what the comment says #197

Merged
merged 1 commit into from
May 21, 2020

Conversation

achamayou
Copy link
Member

Despite the comment, the cmakelist will in fact take "clang-format" and use it even if it's pre-9 and incompatible.

As a pre-9 user (a choice dictated by dependencies I have no control over), this is my preferred fix. I suppose adjusting the comment to match what the cmakelist does would also work.

@achamayou achamayou requested a review from mjp41 May 21, 2020 13:58
Copy link
Member

@mjp41 mjp41 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mjp41 mjp41 merged commit 7ccd6c3 into microsoft:master May 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants