-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added simple stats tracking memory usage #241
Conversation
These statistics can be maintained with effectively zero cost to realistic applications. They do not track the precise amount of memory used, but are an over-approximation.
This is not quite finished as the API is not surfaced properly. After suggestions for what to do.
The C++ code just returns a pair, but I guess we want a C function for broader use. |
Addresses #240 |
Output from the new unit test:
|
I have incorporated your (@davidchisnall, @achamayou ) comments from #240 as best I can. Please check you feel this is a reasonable interpretation of your constraints and suggestions. |
That looks good to me, I think it meets both the requirements of the OE memory tests and those of users deploying Open Enclave-based services who want to monitor their memory usage. |
These statistics can be maintained with effectively zero cost to
realistic applications. They do not track the precise amount of
memory used, but are an over-approximation.