Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Morello CI #590

Merged
merged 3 commits into from
Feb 20, 2023
Merged

Update Morello CI #590

merged 3 commits into from
Feb 20, 2023

Conversation

nwf-msr
Copy link
Contributor

@nwf-msr nwf-msr commented Feb 11, 2023

Motivated by not pinning us to the 2022.05 release any more; other changes while in the vicinity.

@nwf-msr nwf-msr self-assigned this Feb 11, 2023
- Log some details of the build environment

- Remove workarounds overcome by events
For reasons unrelated to snmalloc, it's become more convenient to engage
in a little white lie, as it were, that the CI jobs are not `root` on
the worker nodes.  So I'm testing changes on the cluster orchestration
goo to run the github runner as a non-root user.  However, much as with
GitHub's own runners, the runner user is in the `wheel`, and `root` will
have no password, so we can still `su` up to `root` when needed.

Of course, when we are already root, we can `su` to anyone we like,
including `root`, so these changes are compatible with both the old and
new world order and have been tested with both.
@nwf-msr
Copy link
Contributor Author

nwf-msr commented Feb 20, 2023

I don't think the CI failures are my fault; can I go despite them or should I wait?

Copy link
Member

@mjp41 mjp41 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I think we should move FreeBSD CI out of all checks until it is more reliable again.

@mjp41 mjp41 merged commit 50cb8b8 into microsoft:main Feb 20, 2023
@nwf-msr nwf-msr deleted the 202302-morello-ci branch February 20, 2023 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants