Remote stub #604
Merged
Remote stub #604
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rather than allocating a sizeclass use a stub. This change adds a branch on enqueue.
nwf-msr
approved these changes
Mar 24, 2023
mjp41
added a commit
to mjp41/snmalloc
that referenced
this pull request
Jun 7, 2023
* Alter is_empty * Use a stub in remoteallocator Rather than allocating a sizeclass use a stub. This change adds a branch on enqueue.
nwf-msr
added a commit
that referenced
this pull request
Jan 5, 2024
The introduction of the remote stub back in #604 renamed this function from `is_empty` but did not flip the return value to match. Do so now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This partially address #586. It provides a branch on the enqueue path, which simplifies the code.
This removes the need for the smallest size class to be create when the allocator is first initialised.