Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add miri CI job #3

Merged
merged 1 commit into from
Jul 27, 2022
Merged

Add miri CI job #3

merged 1 commit into from
Jul 27, 2022

Conversation

eholk
Copy link
Contributor

@eholk eholk commented Jul 27, 2022

Adds miri to the GitHub Actions workflow so we get coverage of that on CI now too.

@eholk eholk requested a review from daprilik July 27, 2022 21:47
daprilik
daprilik approved these changes Jul 27, 2022
View reviewed changes
Copy link
Collaborator

@daprilik daprilik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :shipit:

(though I will take this opportunity to once again suggest including rustfmt and/or clippy as part of CI as well 😉)

@eholk
Copy link
Contributor Author

eholk commented Jul 27, 2022

Thanks! I opened #4 about cilppy and rustfmt so I don't forget. Although honestly adding that probably is easier than opening the issue.

@eholk eholk merged commit c5ccdd0 into microsoft:main Jul 27, 2022
@eholk eholk deleted the miri-ci branch July 27, 2022 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daprilik daprilik daprilik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eholk @daprilik