use CREATE_NEW to make this more right

microsoft · Nov 4, 2020 · 31dd278 · 31dd278
1 parent f6ad218
commit 31dd278
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/src/cascadia/TerminalSettingsModel/CascadiaSettingsSerialization.cpp b/src/cascadia/TerminalSettingsModel/CascadiaSettingsSerialization.cpp
@@ -1039,7 +1039,7 @@ const Json::Value& CascadiaSettings::_GetDisabledProfileSourcesJsonObject(const
 
 // Method Description:
 // - Write the current state of CascadiaSettings to our settings file
-// - Create a backup file with the current contents
+// - Create a backup file with the current contents, if one does not exist
 // Arguments:
 // - <none>
 // Return Value:
@@ -1054,10 +1054,10 @@ void CascadiaSettings::WriteSettingsToDisk() const
                                               GENERIC_READ,
                                               FILE_SHARE_READ | FILE_SHARE_WRITE,
                                               nullptr,
-                                              OPEN_EXISTING,
+                                              CREATE_NEW,
                                               FILE_ATTRIBUTE_NORMAL,
                                               nullptr) };
-    if (!backupFile)
+    if (GetLastError() != ERROR_FILE_EXISTS)
     {
         _WriteSettings(_userSettingsString, backupSettingsPath);
     }