A wee bit cleaner

microsoft · Mar 29, 2022 · 43ecfb7 · 43ecfb7
1 parent e59afac
commit 43ecfb7
Show file tree

Hide file tree

Showing 3 changed files with 27 additions and 16 deletions.
diff --git a/src/cascadia/TerminalControl/ControlCore.cpp b/src/cascadia/TerminalControl/ControlCore.cpp
@@ -1696,9 +1696,20 @@ namespace winrt::Microsoft::Terminal::Control::implementation
         }
     }
 
+    // Method Description:
+    // - Notifies the attached PTY that the window has changed visibility state
+    // - NOTE: Most VT commands are generated in `TerminalDispatch` and sent to this
+    //         class as the target for transmission. But since this message isn't
+    //         coming in via VT parsing (and rather from a window state transition)
+    //         we generate and send it here.
+    // Arguments:
+    // - visible: True for visible; false for not visible.
+    // Return Value:
+    // - <none>
     void ControlCore::WindowVisibilityChanged(const bool showOrHide)
     {
-        _terminal->UpdateVisibility(showOrHide);
+        // show is true, hide is false
+        _connection.WriteInput(showOrHide ? L"\x1b[1t" : L"\x1b[2t");
     }
 
     bool ControlCore::_isBackgroundTransparent()

diff --git a/src/cascadia/TerminalCore/Terminal.cpp b/src/cascadia/TerminalCore/Terminal.cpp
@@ -221,20 +221,20 @@ void Terminal::UpdateAppearance(const ICoreAppearance& appearance)
     _defaultCursorShape = cursorShape;
 }
 
-// Method Description:
-// - Notifies the attached PTY that the window has changed visibility state
-// - NOTE: Most VT commands are generated in `TerminalDispatch` and sent to this
-//         class as the target for transmission. But since this message isn't
-//         coming in via VT parsing (and rather from a window state transition)
-//         we generate and send it here.
-// Arguments:
-// - visible: True for visible; false for not visible.
-// Return Value:
-// - <none>
-void Terminal::UpdateVisibility(const bool visible)
-{
-    ReturnResponse(visible ? L"\x1b[1t" : L"\x1b[2t");
-}
+// // Method Description:
+// // - Notifies the attached PTY that the window has changed visibility state
+// // - NOTE: Most VT commands are generated in `TerminalDispatch` and sent to this
+// //         class as the target for transmission. But since this message isn't
+// //         coming in via VT parsing (and rather from a window state transition)
+// //         we generate and send it here.
+// // Arguments:
+// // - visible: True for visible; false for not visible.
+// // Return Value:
+// // - <none>
+// void Terminal::UpdateVisibility(const bool visible)
+// {
+//     ReturnResponse(visible ? L"\x1b[1t" : L"\x1b[2t");
+// }
 
 // Method Description:
 // - Resize the terminal as the result of some user interaction.

diff --git a/src/cascadia/TerminalCore/Terminal.hpp b/src/cascadia/TerminalCore/Terminal.hpp
@@ -75,7 +75,7 @@ class Microsoft::Terminal::Core::Terminal final :
 
     void UpdateSettings(winrt::Microsoft::Terminal::Core::ICoreSettings settings);
     void UpdateAppearance(const winrt::Microsoft::Terminal::Core::ICoreAppearance& appearance);
-    void UpdateVisibility(const bool visible);
+    // void UpdateVisibility(const bool visible);
     void SetFontInfo(const FontInfo& fontInfo);
 
     // Write comes from the PTY and goes to our parser to be stored in the output buffer