polish

microsoft · Oct 28, 2020 · f0b2c01 · f0b2c01
1 parent 1c7e274
commit f0b2c01
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 7 deletions.
diff --git a/src/cascadia/TerminalSettingsModel/CascadiaSettingsSerialization.cpp b/src/cascadia/TerminalSettingsModel/CascadiaSettingsSerialization.cpp
@@ -367,8 +367,6 @@ void CascadiaSettings::_LoadDynamicProfiles()
                 auto profiles = generator->GenerateProfiles();
                 for (auto& profile : profiles)
                 {
-                    // If the profile did not have a GUID when it was generated,
-                    // we'll synthesize a GUID for it in _ValidateProfilesHaveGuid
                     profile.Source(generatorNamespace);
 
                     _allProfiles.Append(profile);

diff --git a/src/cascadia/ut_app/DynamicProfileTests.cpp b/src/cascadia/ut_app/DynamicProfileTests.cpp
@@ -110,8 +110,7 @@ namespace TerminalAppUnitTests
 
     void DynamicProfileTests::TestGenGuidsForProfiles()
     {
-        // We'll generate GUIDs during
-        // CascadiaSettings::_ValidateProfilesHaveGuid. We should make sure that
+        // We'll generate GUIDs in the Profile::Guid getter. We should make sure that
         // the GUID generated for a dynamic profile (with a source) is different
         // than that of a profile without a source.
 
@@ -167,8 +166,6 @@ namespace TerminalAppUnitTests
         VERIFY_IS_FALSE(settings->_profiles.GetAt(4).HasGuid());
         VERIFY_IS_FALSE(settings->_profiles.GetAt(4).Source().empty());
 
-        settings->_ValidateProfilesHaveGuid();
-
         VERIFY_IS_TRUE(settings->_profiles.GetAt(0).HasGuid());
         VERIFY_IS_TRUE(settings->_profiles.GetAt(1).HasGuid());
         VERIFY_IS_TRUE(settings->_profiles.GetAt(2).HasGuid());

diff --git a/src/cascadia/ut_app/JsonTests.cpp b/src/cascadia/ut_app/JsonTests.cpp
@@ -120,7 +120,7 @@ namespace TerminalAppUnitTests
     {
         // Parse some profiles without guids. We should NOT generate new guids
         // for them. If a profile doesn't have a GUID, we'll leave its _guid
-        // set to nullopt. CascadiaSettings::_ValidateProfilesHaveGuid will
+        // set to nullopt. The Profile::Guid() getter will
         // ensure all profiles have a GUID that's actually set.
         // The null guid _is_ a valid guid, so we won't re-generate that
         // guid. null is _not_ a valid guid, so we'll leave that nullopt