Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

alt+space displays system menu *and* sends key binding to Terminal #10935

Closed
DHowett opened this issue Aug 12, 2021 · 1 comment · Fixed by #10988
Closed

alt+space displays system menu *and* sends key binding to Terminal #10935

DHowett opened this issue Aug 12, 2021 · 1 comment · Fixed by #10988
Assignees
@PankajBhojwani
Labels
Area-Input Related to input processing (key presses, mouse, etc.) Area-TerminalControl Issues pertaining to the terminal control (input, selection, keybindings, mouse interaction, etc.) Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-1 A description (P1) Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. Severity-Blocking We won't ship a release like this! No-siree.
Milestone
Terminal v1.11

Comments

@DHowett
Copy link
Member

DHowett commented Aug 12, 2021

Windows Terminal version (or Windows build number)

1.11

Other Software

No response

Steps to reproduce

Press alt-space!

Expected Behavior

No response

Actual Behavior

image

/cc @FWest98 possible fallout from #10799?
@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Aug 12, 2021
@DHowett DHowett added Area-Input Related to input processing (key presses, mouse, etc.) Area-TerminalControl Issues pertaining to the terminal control (input, selection, keybindings, mouse interaction, etc.) Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-1 A description (P1) Product-Terminal The new Windows Terminal. labels Aug 12, 2021
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label Aug 12, 2021
@FWest98
Copy link
Contributor

FWest98 commented Aug 12, 2021

That’s very strange, that shouldn’t happen. I don’t see how my code can produce this behaviour:

https://github.com/microsoft/terminal/pull/10799/files#diff-c10bb023995e88dac6c1d786129284c454c2df739ea547ce462129dc86dc2697R812

In this line and the following, alt+space will only be sent to the terminal when it is explicitly unbound, but then handled will be true always so it shouldn’t trigger the system menu.

So maybe this is somewhere further up, in the main eventhandler loop?

@zadjii-msft zadjii-msft added this to the Terminal v1.11 milestone Aug 16, 2021
@zadjii-msft zadjii-msft added the Severity-Blocking We won't ship a release like this! No-siree. label Aug 16, 2021
@PankajBhojwani PankajBhojwani mentioned this issue Aug 19, 2021
Merged
@ghost ghost added the In-PR This issue has a related PR label Aug 19, 2021
@PankajBhojwani PankajBhojwani self-assigned this Aug 19, 2021
@zadjii-msft zadjii-msft removed the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Aug 23, 2021
@ghost ghost closed this as completed in #10988 Aug 24, 2021
@ghost ghost removed the In-PR This issue has a related PR label Aug 24, 2021
ghost pushed a commit that referenced this issue Aug 24, 2021
@PankajBhojwani
Fix alt+space opening system menu and sending keys to terminal (#10988)
b113126 
If both of the following are true

1. alt+space is not explicitly unbound
2. alt+space is not bound to a command

Then the window procedure will handle the alt+space to open up the context menu.
In this case, we need to make sure we don't send the keys to terminal.

Closes #10935
@ghost ghost added the Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. label Aug 24, 2021
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@PankajBhojwani PankajBhojwani

Labels
Area-Input Related to input processing (key presses, mouse, etc.) Area-TerminalControl Issues pertaining to the terminal control (input, selection, keybindings, mouse interaction, etc.) Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-1 A description (P1) Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. Severity-Blocking We won't ship a release like this! No-siree.
Projects
None yet
Milestone
Terminal v1.11
Development

Successfully merging a pull request may close this issue.

Fix alt+space opening system menu and sending keys to terminal microsoft/terminal
4 participants
@DHowett @FWest98 @zadjii-msft @PankajBhojwani