Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Terminal Preview - Move pane]: Screen reader is not announcing any information when user try to 'Move' tab or 'Move' pane. #15159

Closed
Saiteja341 opened this issue Apr 11, 2023 · 1 comment · Fixed by #15771
Closed

[Terminal Preview - Move pane]: Screen reader is not announcing any information when user try to 'Move' tab or 'Move' pane. #15159

Saiteja341 opened this issue Apr 11, 2023 · 1 comment · Fixed by #15771
Labels
A11ySev2 Accessibility tracking A11yWCAG Accessibility tracking Area-Accessibility Issues related to accessibility HCL-E+D Accessibility tracking HCL-WindowsTerminal Accessibility tracking In-PR This issue has a related PR Issue-Bug It either shouldn't be doing this or needs an investigation. Product-Terminal The new Windows Terminal.
Milestone
Terminal v1.19

Comments

@Saiteja341
Copy link

Windows Terminal version

1.18.902.0

Windows build number

25324.1011

Other Software

Test Environment:
OS: Windows 11 Version Dev (OS Build 25324.1011)
App: Windows Terminal Preview
Screen Reader: Narrator

Steps to reproduce

Prequisite:

  1. Go to setting using 'Ctrl + ,'.
  2. Open 'JSON File'.
  3. Add the following JSON in your terminal’s settings.json within the “actions” array
    { "keys": "f1", "command": { "action": "moveTab", "window": "1" }, },

Repro Steps:

1.Open Windows Terminal.
4.Open multiple 'Command prompt' using 'Ctrl + Shift + 1' keys.
5.Now press F1 to perform 'Move' tab functionality using keyboard.
6.Observe the issue.

Users Experience:
Screen reader users will get impacted if screen reader does not provide information about the moving tab or pane.

Guideline link:
https://www.w3.org/TR/WCAG21/#info-and-relationships

Attachments:
Screen reader is not announcing any information when user try to 'Move' tab or 'Move' pane..zip

Expected Behavior

Screen reader should announce any information when user try to 'Move' tab or 'Move' pane.

Actual Behavior

Screen reader is not announcing any information when user try to 'Move' tab or 'Move' pane.
@Saiteja341 Saiteja341 added Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels Apr 11, 2023
@Priyanka-Chauhan123 Priyanka-Chauhan123 added Area-Accessibility Issues related to accessibility Product-Terminal The new Windows Terminal. HCL-E+D Accessibility tracking A11yWCAG Accessibility tracking HCL-WindowsTerminal Accessibility tracking A11ySev2 Accessibility tracking labels Apr 11, 2023
@zadjii-msft zadjii-msft removed the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Apr 12, 2023
@zadjii-msft zadjii-msft added this to the Terminal v1.19 milestone Apr 13, 2023
@carlos-zamora
Copy link
Member

Screen reader should announce any information when user try to 'Move' tab or 'Move' pane.

This should be easily accomplished using RaiseNotificationEvent.

@carlos-zamora carlos-zamora mentioned this issue Jul 27, 2023
Merged
@microsoft-github-policy-service microsoft-github-policy-service bot added the In-PR This issue has a related PR label Jul 27, 2023
microsoft-github-policy-service bot pushed a commit that referenced this issue Aug 25, 2023
@carlos-zamora
Make screen reader announce successful MovePane and MoveTab actions (#…
2fb4a7f 
…15771)

Uses the `RaiseNotificationEvent()` API from UIA automation peers to
announce successful `MovePane` and `MoveTab` actions. The announcements
are localized in the resw file.

Closes #15159
Based on #13575
DHowett pushed a commit that referenced this issue Sep 22, 2023
@carlos-zamora @DHowett
Make screen reader announce successful MovePane and MoveTab actions (#…
eff8cfa 
…15771)

Uses the `RaiseNotificationEvent()` API from UIA automation peers to
announce successful `MovePane` and `MoveTab` actions. The announcements
are localized in the resw file.

Closes #15159
Based on #13575

(cherry picked from commit 2fb4a7f)
Service-Card-Id: 90438494
Service-Version: 1.18
@carlos-zamora carlos-zamora mentioned this issue Oct 3, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A11ySev2 Accessibility tracking A11yWCAG Accessibility tracking Area-Accessibility Issues related to accessibility HCL-E+D Accessibility tracking HCL-WindowsTerminal Accessibility tracking In-PR This issue has a related PR Issue-Bug It either shouldn't be doing this or needs an investigation. Product-Terminal The new Windows Terminal.
Projects
None yet
Milestone
Terminal v1.19
Development

Successfully merging a pull request may close this issue.

Make screen reader announce successful MovePane and MoveTab actions microsoft/terminal
4 participants
@carlos-zamora @zadjii-msft @Priyanka-Chauhan123 @Saiteja341