Do not pad tabs from the top when maximized or fullscreen #2541
Assignees
Labels
Area-User Interface
Issues pertaining to the user interface of the Console or Terminal
Help Wanted
We encourage anyone to jump in on these.
Issue-Bug
It either shouldn't be doing this or needs an investigation.
Priority-3
A description (P3)
Product-Terminal
The new Windows Terminal.
Resolution-Fix-Committed
Fix is checked in, but it might be 3-4 weeks until a release.
Milestone
Comments
trajano
added
the
Issue-Feature
ghost
added
Needs-Triage
|
They are aware of it, as it has been mentioned in #1375, under “Things related to tabs” |
Edge (or Chrome for that matter) aren't responsible for it. Chromium is. Since Terminal isn't Chromium based, re-use can't happen. Incidentally, I (along with many others) would prefer a menu bar like IE in Edge. I actually opened a ticket for it on the Chromium bug tracker but will probably need more input on the bug tracker to get any type of action on it. Honestly a menu bar in Terminal would be great as well and I'm sure it will be addressed in #1375. |
zadjii-msft
added
Area-User Interface
DHowett-MSFT
removed
the
Needs-Triage
29 tasks
zadjii-msft
added
Issue-Bug
|
To not lose context: in |
|
Thanks! |
zadjii-msft
changed the title
Closed
This was referenced May 13, 2020
This was referenced May 21, 2020
ghost
pushed a commit
that referenced
this issue
May 21, 2020
## Summary of the Pull Request When we maximize the window, shrink the caption buttons (the min, max, close buttons) down to 32px tall, to be the same height as the `TabRowControl`. This way, the tabs will be flush with the top of the display. ## PR Checklist * [x] Closes #2541 * [x] I work here * [ ] Tests added/passed * [n/a] Requires documentation to be updated ## Detailed Description of the Pull Request / Additional comments I tried for a couple hours this morning to do this as a `VisualState`. First I tried doing it as one on the TabRow, which I had very little success with. Then, I eventually realized that the TabRow wasn't even responsible for the padding there, it was being created by the fact that the caption buttons were too tall. Again, I tried to use the existing `VisualState`s they have defined for this, but I couldn't figure out how to do that. I think the visual state solution would be _cleaner_, so if someone knows how to do that instead, please let me know. ## Validation Steps Performed * Maximized/restored the Terminal on my display with the taskbar on the bottom * Maximized/restored the Terminal on my display with the taskbar on the top
ghost
added
Resolution-Fix-Committed
jelster
pushed a commit
to jelster/terminal
that referenced
this issue
May 28, 2020
## Summary of the Pull Request When we maximize the window, shrink the caption buttons (the min, max, close buttons) down to 32px tall, to be the same height as the `TabRowControl`. This way, the tabs will be flush with the top of the display. ## PR Checklist * [x] Closes microsoft#2541 * [x] I work here * [ ] Tests added/passed * [n/a] Requires documentation to be updated ## Detailed Description of the Pull Request / Additional comments I tried for a couple hours this morning to do this as a `VisualState`. First I tried doing it as one on the TabRow, which I had very little success with. Then, I eventually realized that the TabRow wasn't even responsible for the padding there, it was being created by the fact that the caption buttons were too tall. Again, I tried to use the existing `VisualState`s they have defined for this, but I couldn't figure out how to do that. I think the visual state solution would be _cleaner_, so if someone knows how to do that instead, please let me know. ## Validation Steps Performed * Maximized/restored the Terminal on my display with the taskbar on the bottom * Maximized/restored the Terminal on my display with the taskbar on the top
|
🎉This issue was addressed in #5881, which has now been successfully released as Handy links: |
DHowett
pushed a commit
that referenced
this issue
Jun 24, 2020
## Summary of the Pull Request When we maximize the window, shrink the caption buttons (the min, max, close buttons) down to 32px tall, to be the same height as the `TabRowControl`. This way, the tabs will be flush with the top of the display. ## PR Checklist * [x] Closes #2541 * [x] I work here * [ ] Tests added/passed * [n/a] Requires documentation to be updated ## Detailed Description of the Pull Request / Additional comments I tried for a couple hours this morning to do this as a `VisualState`. First I tried doing it as one on the TabRow, which I had very little success with. Then, I eventually realized that the TabRow wasn't even responsible for the padding there, it was being created by the fact that the caption buttons were too tall. Again, I tried to use the existing `VisualState`s they have defined for this, but I couldn't figure out how to do that. I think the visual state solution would be _cleaner_, so if someone knows how to do that instead, please let me know. ## Validation Steps Performed * Maximized/restored the Terminal on my display with the taskbar on the bottom * Maximized/restored the Terminal on my display with the taskbar on the top (cherry picked from commit c373ebc)
|
🎉This issue was addressed in #5881, which has now been successfully released as Handy links: |
|
Is there a reason why a padding must exists for a floating window? |
|
It's what every other commonly-used tabbed application has padding above the tabs for a drag/resize area, except for perhaps Firefox. |
|
Im using Chrome Edge and even in floating window there is enough gap to drag the window no matter how many tabs you add. And yes Firefox does it best. |
This issue was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description of the new feature/enhancement
Edge and most other programs that use tabs where a menu bar is not present keep the tabs flush to the top of the screen rather than padding it down.
Proposed technical implementation details (optional)
Make Terminal consistent with Edge Dev (ideally use the same code if possible) to render the tabs on top.
The text was updated successfully, but these errors were encountered: