Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug Report: Misaligned UIA text range bounding rectangles in displays that are not 100%-scale #2551

Closed
cinnamon-msft opened this issue Aug 26, 2019 · 1 comment · Fixed by #4497
Closed

Bug Report: Misaligned UIA text range bounding rectangles in displays that are not 100%-scale #2551

cinnamon-msft opened this issue Aug 26, 2019 · 1 comment · Fixed by #4497
Assignees
@carlos-zamora
Labels
Area-Accessibility Issues related to accessibility Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-1 A description (P1) Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Milestone
Terminal v0.10

Comments

@cinnamon-msft
Copy link
Contributor

Environment

Not 100%-scale display (high DPI monitor)

Windows build number: Microsoft Windows [Version 10.0.18853.1000]
Windows Terminal version (if applicable): v0.4

Any other software?

Steps to reproduce

Expected behavior

Rectangles should properly surround text inside the text buffer.

Actual behavior

No alignment or sizing - displaying in the top left corner.
@cinnamon-msft cinnamon-msft added Issue-Bug It either shouldn't be doing this or needs an investigation. Area-Accessibility Issues related to accessibility Product-Terminal The new Windows Terminal. labels Aug 26, 2019
@cinnamon-msft cinnamon-msft added this to the Terminal 1909 milestone Aug 26, 2019
@ghost ghost added the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Aug 26, 2019
@cinnamon-msft cinnamon-msft removed the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Aug 26, 2019
@DHowett-MSFT DHowett-MSFT changed the title Bug Report: Misaligned bounding rectangles in displays that are not 100%-scale Bug Report: Misaligned UIA text range bounding rectangles in displays that are not 100%-scale Aug 26, 2019
@zadjii-msft zadjii-msft added the Priority-3 A description (P3) label Jan 22, 2020
@cinnamon-msft cinnamon-msft added Priority-1 A description (P1) and removed Priority-3 A description (P3) labels Jan 28, 2020
@carlos-zamora carlos-zamora mentioned this issue Feb 7, 2020
Merged
2 tasks
@ghost ghost added the In-PR This issue has a related PR label Feb 7, 2020
@ghost ghost closed this as completed in #4497 Feb 11, 2020
ghost pushed a commit that referenced this issue Feb 11, 2020
@carlos-zamora
Fix UiaTextRange Misaligned Bounding Rects (#4497)
3b58e04 
## Summary of the Pull Request
Forgot to include the scaling factor. Also went ahead and used chromium math for this portion.

## References

<!-- Please review the items on the PR checklist before submitting-->
## PR Checklist
* [x] Closes #2551
* [x] CLA signed.

## Validation Steps Performed
Tested on 200% display and 100% display. Rects are aligned on both.
@ghost ghost removed the In-PR This issue has a related PR label Feb 11, 2020
@ghost ghost added the Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. label Feb 11, 2020
@carlos-zamora carlos-zamora mentioned this issue Feb 11, 2020
Closed
22 tasks
@ghost
Copy link

ghost commented Feb 13, 2020

🎉This issue was addressed in #4497, which has now been successfully released as Windows Terminal Preview v0.9.433.0.:tada:

Handy links:

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@carlos-zamora carlos-zamora

Labels
Area-Accessibility Issues related to accessibility Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-1 A description (P1) Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Projects
None yet
Milestone
Terminal v0.10
Development

Successfully merging a pull request may close this issue.

Fix UiaTextRange Misaligned Bounding Rects microsoft/terminal
3 participants
@carlos-zamora @zadjii-msft @cinnamon-msft