Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Crash if Narrator open #2907

Closed
carlos-zamora opened this issue Sep 25, 2019 · 4 comments · Fixed by #4505
Closed

Crash if Narrator open #2907

carlos-zamora opened this issue Sep 25, 2019 · 4 comments · Fixed by #4505
Assignees
@DHowett-MSFT
Labels
Area-Accessibility Issues related to accessibility Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-0 Bugs that we consider release-blocking/recall-class (P0) Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. Severity-Crash Crashes are real bad news.
Milestone
Terminal v1.0

Comments

@carlos-zamora
Copy link
Member

Environment

Windows build number: Microsoft Windows [Version 10.0.18991.1000]
Windows Terminal version (if applicable): 0.5

Any other software?

Steps to reproduce

  1. Ensure Windows Terminal isn't open
  2. Open Narrator (if it isn't open already)
  3. Open Windows Terminal

Expected behavior

Windows Terminal opens

Actual behavior

Crash :(
@carlos-zamora carlos-zamora added Issue-Bug It either shouldn't be doing this or needs an investigation. Area-Accessibility Issues related to accessibility Severity-Crash Crashes are real bad news. Product-Terminal The new Windows Terminal. labels Sep 25, 2019
@ghost ghost added the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Sep 25, 2019
@carlos-zamora
Copy link
Member Author

@DHowett-MSFT and I investigated this. It seems to be an issue with the TabViewItem's Icons on startup?

Current workaround is to open Narrator after Windows Terminal is open.

@DHowett-MSFT DHowett-MSFT removed the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Sep 26, 2019
@DHowett-MSFT
Copy link
Contributor

My job to follow up with MUXC -- it looks like their visual tree is stumping the non-visual-tree visual tree reader.

@DHowett-MSFT
Copy link
Contributor

tree. Blocked behind #1896 (FYI)

@zadjii-msft zadjii-msft added this to the Terminal v1.0 milestone Dec 19, 2019
@zadjii-msft zadjii-msft added the Priority-1 A description (P1) label Jan 22, 2020
@cinnamon-msft cinnamon-msft added v1-Scrubbed Priority-0 Bugs that we consider release-blocking/recall-class (P0) and removed Priority-1 A description (P1) labels Jan 23, 2020
@DHowett-MSFT DHowett-MSFT mentioned this issue Feb 7, 2020
Merged
@ghost ghost added the In-PR This issue has a related PR label Feb 7, 2020
@ghost ghost closed this as completed in #4505 Feb 10, 2020
ghost pushed a commit that referenced this issue Feb 10, 2020
@DHowett
Initialize Windows Terminal in STA (#4505)
cc371b0 
This fixes a crash caused by Narrator starting *before* terminal.

Fixes #2907.

For context,

```
// We must initialize the main thread as a single-threaded apartment before
// constructing any Xaml objects. Failing to do so will cause some issues
// in accessibility somewhere down the line when a UIAutomation object will
// be queried on the wrong thread at the wrong time.
// We used to initialize as STA only _after_ initializing the application
// host, which loaded the settings. The settings needed to be loaded in MTA
// because we were using the Windows.Storage APIs. Since we're no longer
// doing that, we can safely init as STA before any WinRT dispatches.
```
@ghost ghost added Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. and removed In-PR This issue has a related PR labels Feb 10, 2020
@carlos-zamora carlos-zamora mentioned this issue Feb 11, 2020
Closed
22 tasks
@ghost
Copy link

ghost commented Feb 13, 2020

🎉This issue was addressed in #4505, which has now been successfully released as Windows Terminal Preview v0.9.433.0.:tada:

Handy links:

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DHowett-MSFT DHowett-MSFT

Labels
Area-Accessibility Issues related to accessibility Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-0 Bugs that we consider release-blocking/recall-class (P0) Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. Severity-Crash Crashes are real bad news.
Projects
None yet
Milestone
Terminal v1.0
Development

Successfully merging a pull request may close this issue.

Initialize Windows Terminal in STA microsoft/terminal
4 participants
@carlos-zamora @DHowett-MSFT @zadjii-msft @cinnamon-msft