Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Windows Terminal does not open with button displaying "maximized" state #3440

Closed
mu88 opened this issue Nov 5, 2019 · 3 comments · Fixed by #5988
Closed

Windows Terminal does not open with button displaying "maximized" state #3440

mu88 opened this issue Nov 5, 2019 · 3 comments · Fixed by #5988
Assignees
@zadjii-msft
Labels
Area-User Interface Issues pertaining to the user interface of the Console or Terminal Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-3 A description (P3) Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Milestone
Terminal v1.x

Comments

@mu88
Copy link

mu88 commented Nov 5, 2019

Environment

Windows build number: Microsoft Windows [Version 10.0.18362.418]
Windows Terminal version (if applicable): 0.6.2951.0

Steps to reproduce

Set "launchMode": "maximized" within profiles.json

Expected behavior

Windows Terminal opens maximized.

Actual behavior

Windows Terminal opens with maximum screen size, but not maximized (see screenshots).
wrong (actual implementation): wrong
correct: correct
@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Nov 5, 2019
@DHowett-MSFT DHowett-MSFT changed the title Windows Terminal does not open "maximized" Windows Terminal does not open with button displaying "maximized" state Nov 7, 2019
@zadjii-msft zadjii-msft added Area-User Interface Issues pertaining to the user interface of the Console or Terminal Issue-Bug It either shouldn't be doing this or needs an investigation. Product-Terminal The new Windows Terminal. labels Nov 7, 2019
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label Nov 7, 2019
@zadjii-msft zadjii-msft added this to the Terminal v1.0 milestone Nov 7, 2019
@zadjii-msft zadjii-msft added Priority-3 A description (P3) and removed Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels Nov 7, 2019
@DHowett-MSFT DHowett-MSFT mentioned this issue Jan 23, 2020
Closed
29 tasks
@trajano
Copy link

trajano commented May 19, 2020

One other thing, the original size is also lost so when you launch again, you have to manually resize the window again.

@zadjii-msft zadjii-msft self-assigned this May 19, 2020
@zadjii-msft zadjii-msft mentioned this issue May 19, 2020
Merged
3 tasks
@ghost ghost added the In-PR This issue has a related PR label May 19, 2020
@ghost ghost closed this as completed in #5988 May 21, 2020
ghost pushed a commit that referenced this issue May 21, 2020
@zadjii-msft
Make sure to update the maximize button's visual state on launch (#5988)
2af722b 
## Summary of the Pull Request
This is an enormously trivial nit - when we launch maximized, we don't draw the maximize button in the "restore" state.

This PR changes the terminal to manually update the Maximize button on launch, once the titlebar is added to the UI tree.

## PR Checklist
* [x] Closes #3440
* [x] I work here
* [ ] Tests added/passed
* [n/a] Requires documentation to be updated
@ghost ghost added Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. and removed In-PR This issue has a related PR labels May 21, 2020
jelster pushed a commit to jelster/terminal that referenced this issue May 28, 2020
@zadjii-msft @jelster
Make sure to update the maximize button's visual state on launch (mic…
6a135ab 
…rosoft#5988)

## Summary of the Pull Request
This is an enormously trivial nit - when we launch maximized, we don't draw the maximize button in the "restore" state.

This PR changes the terminal to manually update the Maximize button on launch, once the titlebar is added to the UI tree.

## PR Checklist
* [x] Closes microsoft#3440
* [x] I work here
* [ ] Tests added/passed
* [n/a] Requires documentation to be updated
@DHowett DHowett mentioned this issue Jun 5, 2020
Closed
@ghost
Copy link

ghost commented Jun 18, 2020

🎉This issue was addressed in #5988, which has now been successfully released as Windows Terminal Preview v1.1.1671.0.:tada:

Handy links:

DHowett pushed a commit that referenced this issue Jun 24, 2020
@zadjii-msft @DHowett
Make sure to update the maximize button's visual state on launch (#5988)
b592d5b 
## Summary of the Pull Request
This is an enormously trivial nit - when we launch maximized, we don't draw the maximize button in the "restore" state.

This PR changes the terminal to manually update the Maximize button on launch, once the titlebar is added to the UI tree.

## PR Checklist
* [x] Closes #3440
* [x] I work here
* [ ] Tests added/passed
* [n/a] Requires documentation to be updated

(cherry picked from commit 2af722b)
@ghost
Copy link

ghost commented Jun 30, 2020

🎉This issue was addressed in #5988, which has now been successfully released as Windows Terminal v1.0.1811.0.:tada:

Handy links:

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zadjii-msft zadjii-msft

Labels
Area-User Interface Issues pertaining to the user interface of the Console or Terminal Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-3 A description (P3) Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Projects
None yet
Milestone
Terminal v1.x
Development

Successfully merging a pull request may close this issue.

Make sure to update the maximize button's visual state on launch microsoft/terminal
4 participants
@trajano @mu88 @zadjii-msft @cinnamon-msft