Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hidden profiles are deleted, not hidden #4139

Closed
DHowett-MSFT opened this issue Jan 7, 2020 · 3 comments · Fixed by #8070
Closed

hidden profiles are deleted, not hidden #4139

DHowett-MSFT opened this issue Jan 7, 2020 · 3 comments · Fixed by #8070
Assignees
@DHowett
Labels
Area-Settings Issues related to settings and customizability, for console or terminal Issue-Task It's a feature request, but it doesn't really need a major design. Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Milestone
Terminal v2.0

Comments

@DHowett-MSFT
Copy link
Contributor

Right now, "hiding" a profile totally deletes it. This has some interesting effects on profiles that are in active use - their icons and background images disappear, and their closeOnExits get ignored. Anything that relies on the presence of a profile for a given tab fails.

I'm wondering if hidden shouldn't just mean "don't show in the list". This has other interesting follow-on questions: should a profile that's been hidden still be launchable with a keyboard shortcut that specifically targets it? should a hidden profile be defaultable? I don't totally see why not.

Partially related to [workitem for customizing the dropdown menu].
@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Jan 7, 2020
@zadjii-msft zadjii-msft added Area-Settings Issues related to settings and customizability, for console or terminal Product-Terminal The new Windows Terminal. Issue-Task It's a feature request, but it doesn't really need a major design. labels Jan 9, 2020
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label Jan 9, 2020
@DHowett-MSFT DHowett-MSFT removed the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Jan 9, 2020
@DHowett-MSFT DHowett-MSFT added this to the Terminal Backlog milestone Jan 9, 2020
@acshef
Copy link

acshef commented Feb 18, 2020 •
edited
Loading

A hidden profile also can't be started using the command line argument wt -p introduced in v0.9. I believe that behavior to be a bug. The generally observed behavior of "hidden things" in UX/UI is that they can still be accessed explicitly -- I view that as one of the principal distinctions between hidden and deleted things.

@DHowett-MSFT DHowett-MSFT mentioned this issue Mar 2, 2020
Closed
@DHowett-MSFT DHowett-MSFT mentioned this issue May 15, 2020
Closed
@DHowett DHowett assigned DHowett and unassigned DHowett-MSFT May 17, 2020
This was referenced Jul 9, 2020
Closed
Merged
@zadjii-msft

This comment has been minimized.

Sign in to view
@DHowett DHowett mentioned this issue Oct 11, 2020
Closed
@carlos-zamora carlos-zamora mentioned this issue Oct 28, 2020
Merged
2 tasks
@ghost ghost added the In-PR This issue has a related PR label Oct 28, 2020
@ghost ghost closed this as completed in #8070 Oct 28, 2020
@ghost ghost added Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. and removed In-PR This issue has a related PR labels Oct 28, 2020
ghost pushed a commit that referenced this issue Oct 28, 2020
@carlos-zamora
Store and expose hidden profiles (#8070)
242833f 
## Summary of the Pull Request
This PR replaces `CascadiaSettings::_profiles` with...
- `_allProfiles`: the list of all available profiles in the settings model (i.e. settings.json, dynamic profiles, etc...)
- `_activeProfiles`: the list of all non-hidden profiles (used for the new tab dropdown)

## References
#8018: maintaining a list of all profiles allows us to serialize hidden profiles
#1564: Settings UI can link to `AllProfiles()` instead of `ActiveProfiles()` to expose hidden profiles

## PR Checklist
* [x] Closes #4139 
* [x] Tests added/passed

## Validation Steps Performed
Deploy and testing succeeded
@ghost
Copy link

ghost commented Nov 11, 2020

🎉This issue was addressed in #8070, which has now been successfully released as Windows Terminal Preview v1.5.3142.0.:tada:

Handy links:

@DHowett DHowett mentioned this issue Nov 23, 2020
Closed
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DHowett DHowett

Labels
Area-Settings Issues related to settings and customizability, for console or terminal Issue-Task It's a feature request, but it doesn't really need a major design. Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Projects
None yet
Milestone
Terminal v2.0
Development

Successfully merging a pull request may close this issue.

Store and expose hidden profiles microsoft/terminal
5 participants
@DHowett @acshef @DHowett-MSFT @zadjii-msft @cinnamon-msft