Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Cascadia Code the default font #4943

Closed
cinnamon-msft opened this issue Mar 16, 2020 · 1 comment · Fixed by #5121
Closed

Make Cascadia Code the default font #4943

cinnamon-msft opened this issue Mar 16, 2020 · 1 comment · Fixed by #5121
Assignees
@cinnamon-msft
Labels
Area-Fonts Related to the font Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-2 A description (P2) Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Milestone
Terminal v1.0

Comments

@cinnamon-msft
Copy link
Contributor

Environment

Windows build number: [run `[Environment]::OSVersion` for powershell, or `ver` for cmd]
Windows Terminal version (if applicable):

Any other software?

Steps to reproduce

Expected behavior

The default font should be Cascadia Code :)

Actual behavior

The default font is Consolas
@cinnamon-msft cinnamon-msft added Area-Fonts Related to the font Issue-Bug It either shouldn't be doing this or needs an investigation. Product-Terminal The new Windows Terminal. Priority-2 A description (P2) labels Mar 16, 2020
@cinnamon-msft cinnamon-msft added this to the Terminal v1.0 milestone Mar 16, 2020
@cinnamon-msft cinnamon-msft self-assigned this Mar 16, 2020
@ghost ghost added the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Mar 16, 2020
@zadjii-msft zadjii-msft added v1-Scrubbed and removed Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels Mar 16, 2020
@cinnamon-msft cinnamon-msft mentioned this issue Mar 25, 2020
Merged
5 tasks
@ghost ghost added the In-PR This issue has a related PR label Mar 25, 2020
@ghost ghost closed this as completed in #5121 Mar 25, 2020
@ghost ghost added Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. and removed In-PR This issue has a related PR labels Mar 25, 2020
ghost pushed a commit that referenced this issue Mar 25, 2020
@cinnamon-msft
Set Cascadia Code as default font (#5121)
d193c7e 
## Summary of the Pull Request
Changes default font from Consolas to Cascadia Code.

## PR Checklist
* [x] Closes #4943 
* [x] CLA signed. If not, go over [here](https://cla.opensource.microsoft.com/microsoft/Terminal) and sign the CLA
* [ ] Tests added/passed
* [ ] Requires documentation to be updated
* [x] I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #xxx

## Validation Steps Performed
I deleted my profiles.json and built from source. All profiles appeared in Cascadia Code.
@ghost
Copy link

ghost commented Apr 22, 2020

🎉This issue was addressed in #5121, which has now been successfully released as Windows Terminal Preview v0.11.1121.0.:tada:

Handy links:

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cinnamon-msft cinnamon-msft

Labels
Area-Fonts Related to the font Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-2 A description (P2) Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Projects
None yet
Milestone
Terminal v1.0
Development

Successfully merging a pull request may close this issue.

Set Cascadia Code as default font microsoft/terminal
2 participants
@zadjii-msft @cinnamon-msft