Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

A11y_Windows Terminal_Open any Application_Color Contrast: While Opening any application which is not existing then the error message will be displayed and it is not meeting the color contrast ratio 4.5:1 #5393

Closed
SpandanaPaladi opened this issue Apr 17, 2020 · 3 comments
Closed

A11y_Windows Terminal_Open any Application_Color Contrast: While Opening any application which is not existing then the error message will be displayed and it is not meeting the color contrast ratio 4.5:1 #5393

SpandanaPaladi opened this issue Apr 17, 2020 · 3 comments
Assignees
@carlos-zamora
Labels
Area-Accessibility Issues related to accessibility Issue-Task It's a feature request, but it doesn't really need a major design. Product-Terminal The new Windows Terminal. Resolution-Fix-Available It's available in an Insiders build or a release
Milestone
Terminal v1.0

Comments

@SpandanaPaladi
Copy link

SpandanaPaladi commented Apr 17, 2020 •
edited
Loading

#A11y_WindowsTerminal; #WindowsTerminal; #A11yMAS; #A11yTCS; #DesktopApp; #Win10; #C+E-H; #ColorContrast; #A11ySev1; #BenchMark; #MAS1.4.3

Check out Accessibility Insights! - Identify accessibility bugs before check-in and make bug fixing faster and easier

Environment Details:
Version: 0.10.781.0

Repro steps:

  1. Hit the URL ""aka.ms/terminal"" and install ""Windows terminal (Preview)"" application
  2. Open ""Windows terminal (Preview)"" application
  3. Open the "Accessibility insights" tool to check color contrast ratio
  4. Tab to ""Windows Powershell"" tab
  5. Type any application name which is not existing(displays an error message)
  6. Verify whether the color contrast ratio for the error message displayed is meeting 4.5:1 contrast ratio

Actual Result:​
The "Error" message which is displayed is not meeting 4.5:1 contrast ratio

Expected Result:​
The "Error" message which is displayed should meet 4.5:1 contrast ratio
​
User Impact:​
Low vision users will face difficulty in viewing the text if the text Error message fails to meet the contrast ratio 4,.5:1

MAS Reference:​
https://microsoft.sharepoint.com/:w:/r/teams/msenable/_layouts/15/WopiFrame.aspx?sourcedoc={a73546c7-765f-489c-b18f-afb659fe99e6}

Bug_color contrast fails for error message
@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Apr 17, 2020
@zadjii-msft zadjii-msft added Area-Accessibility Issues related to accessibility Product-Terminal The new Windows Terminal. labels Apr 17, 2020
@DHowett-MSFT DHowett-MSFT removed the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Apr 20, 2020
@carlos-zamora
Copy link
Member

Moving this one over to v1.0 milestone because we discussed offline that changing the color scheme to Campbell should suffice. (assuming Campbell provides a good color contrast)

@carlos-zamora carlos-zamora added the Issue-Task It's a feature request, but it doesn't really need a major design. label Apr 20, 2020
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label Apr 20, 2020
@carlos-zamora carlos-zamora mentioned this issue Apr 20, 2020
Merged
1 task
@ghost ghost added In-PR This issue has a related PR and removed In-PR This issue has a related PR labels Apr 20, 2020
DHowett-MSFT pushed a commit that referenced this issue Apr 21, 2020
@carlos-zamora
Change Windows Powershell default scheme to Campbell (#5432)
8a976c0 
The "Campbell Powershell" color scheme does not have a high enough color contrast
ratio. Campbell does, so we're changing it there.

Closes (only upon validation) #5393.
@zadjii-msft zadjii-msft added the Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. label Apr 21, 2020
@carlos-zamora
Copy link
Member

#5432 is included in 0.11. Updating tag.

@carlos-zamora carlos-zamora added Resolution-Fix-Available It's available in an Insiders build or a release and removed Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. labels Apr 22, 2020
@Amulya-95
Copy link

Regressed the bug in latest environment. The issue is resolved, contrast ratio for "Error" message is greater than 4.5:1 ratio. Hence closing this bug.

Fixed Bug 5393_Color contrast ratio passes for error message

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@carlos-zamora carlos-zamora

Labels
Area-Accessibility Issues related to accessibility Issue-Task It's a feature request, but it doesn't really need a major design. Product-Terminal The new Windows Terminal. Resolution-Fix-Available It's available in an Insiders build or a release
Projects
None yet
Milestone
Terminal v1.0
Development

No branches or pull requests
5 participants
@carlos-zamora @DHowett-MSFT @zadjii-msft @Amulya-95 @SpandanaPaladi