Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Split Pane via New Tab button #6757

Closed
jawn opened this issue Jul 2, 2020 · 4 comments · Fixed by #7117
Closed

Support Split Pane via New Tab button #6757

jawn opened this issue Jul 2, 2020 · 4 comments · Fixed by #7117
Assignees
@PankajBhojwani
Labels
Area-User Interface Issues pertaining to the user interface of the Console or Terminal good first issue This is a fix that might be easier for someone to do as a first contribution Help Wanted We encourage anyone to jump in on these. Issue-Task It's a feature request, but it doesn't really need a major design. Priority-2 A description (P2) Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Milestone
Terminal v1.x

Comments

@jawn
Copy link

jawn commented Jul 2, 2020 •
edited
Loading

Description of the new feature/enhancement

There are two ways to add a pane:

  • from the profile menu
  • using the New Tab button.

A a user, I wish to have auto split pane in both cases. Currently, in version 1.1 preview, only the profile menu supports this.

Ways to add a paneFrom the profile menuUsing the New Tab button (the button with a plus symbol).
Auto split pane supported?Alt+Click #5928 

Not supported yet

 

Suggestion: Alt+Click on the New Tab putton auto-splits using the default profile

References

#5928
#5025
@jawn jawn added the Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. label Jul 2, 2020
@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Jul 2, 2020
@DHowett
Copy link
Member

DHowett commented Jul 2, 2020

I am shocked that we missed this.

Thanks.

@DHowett DHowett added Area-User Interface Issues pertaining to the user interface of the Console or Terminal Help Wanted We encourage anyone to jump in on these. Issue-Task It's a feature request, but it doesn't really need a major design. Priority-2 A description (P2) Product-Terminal The new Windows Terminal. and removed Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. labels Jul 2, 2020
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label Jul 2, 2020
@DHowett DHowett modified the milestones: Terminal v2.0, Terminal v1.x Jul 2, 2020
@DHowett DHowett removed the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Jul 2, 2020
@DHowett
Copy link
Member

DHowett commented Jul 2, 2020

/cc @carlos-zamora

@carlos-zamora
Copy link
Member

That's fair, didn't think of that.

@zadjii-msft zadjii-msft added the good first issue This is a fix that might be easier for someone to do as a first contribution label Jul 6, 2020
@PankajBhojwani PankajBhojwani mentioned this issue Jul 29, 2020
Merged
4 tasks
@ghost ghost added the In-PR This issue has a related PR label Jul 29, 2020
@ghost ghost closed this as completed in #7117 Jul 31, 2020
@ghost ghost removed the In-PR This issue has a related PR label Jul 31, 2020
ghost pushed a commit that referenced this issue Jul 31, 2020
@PankajBhojwani
Implement split pane with new tab button (#7117)
8b669b5 
Allows splitting pane (with default settings) by holding down ALT and pressing the new tab button ('+')

## PR Checklist
* [X] Closes #6757 
* [X] Works here.
* [X] Manual test (below)
* [X] Is core contributor. 

## More detailed description

Pretty much exactly the code added in #5928 (all credit to @carlos-zamora), but put at the new tab button event binding

## Validation steps

Seems to work - holding ALT while pressing '+' opens a pane instead of a tab. Holding ALT while starting up terminal for the first time does not seem to affect the behaviour.
@ghost ghost added the Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. label Jul 31, 2020
DHowett pushed a commit that referenced this issue Aug 4, 2020
@PankajBhojwani @DHowett
Implement split pane with new tab button (#7117)
39a1ce0 
Allows splitting pane (with default settings) by holding down ALT and pressing the new tab button ('+')

## PR Checklist
* [X] Closes #6757
* [X] Works here.
* [X] Manual test (below)
* [X] Is core contributor.

## More detailed description

Pretty much exactly the code added in #5928 (all credit to @carlos-zamora), but put at the new tab button event binding

## Validation steps

Seems to work - holding ALT while pressing '+' opens a pane instead of a tab. Holding ALT while starting up terminal for the first time does not seem to affect the behaviour.

(cherry picked from commit 8b669b5)
@ghost
Copy link

ghost commented Aug 13, 2020

🎉This issue was addressed in #7117, which has now been successfully released as Windows Terminal Preview v1.2.2234.0.:tada:

Handy links:

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@PankajBhojwani PankajBhojwani

Labels
Area-User Interface Issues pertaining to the user interface of the Console or Terminal good first issue This is a fix that might be easier for someone to do as a first contribution Help Wanted We encourage anyone to jump in on these. Issue-Task It's a feature request, but it doesn't really need a major design. Priority-2 A description (P2) Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Projects
None yet
Milestone
Terminal v1.x
Development

Successfully merging a pull request may close this issue.

Implement split pane with new tab button microsoft/terminal
5 participants
@DHowett @jawn @carlos-zamora @zadjii-msft @PankajBhojwani