Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tab Switcher occasionally stops updating tab order properly #8185

Closed
DHowett opened this issue Nov 7, 2020 · 6 comments · Fixed by #8188
Closed

Tab Switcher occasionally stops updating tab order properly #8185

DHowett opened this issue Nov 7, 2020 · 6 comments · Fixed by #8188
Labels
Area-User Interface Issues pertaining to the user interface of the Console or Terminal Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-1 A description (P1) Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. Severity-Blocking We won't ship a release like this! No-siree.
Milestone
Terminal v1.5

Comments

@DHowett
Copy link
Member

DHowett commented Nov 7, 2020

I do not know how to get terminal into this state, but I know that I cannot get it out of this state.

When I am using MRU switching, I occasionally get into a "switcher hole" where it puts the tabs in the wrong order with the current tab being selected as the next tab. Result: my switcher takes me to the current tab.

It seems to dislike the 0th tab

current tab (0) is the 2nd tab (1) and is selected by a basic switch operation

When I switch to inOrder switching, the list does not update from MRU order (!) during hot reload, so I can't test it out.

When I open the tab search it remains in MRU order.

A screenshot of my tabs in "in-order" order where the top tab is.. not correct

Adding tabs doesn't seem to break or fix this; they just get added.

This could be a conflict between @zadjii-msft and @Don-Vito's recent work in this area.
Something is unusual with the 0th tab.

Marking blocking because I managed to trivially run into it three times today.
@DHowett DHowett added Issue-Bug It either shouldn't be doing this or needs an investigation. Area-User Interface Issues pertaining to the user interface of the Console or Terminal Product-Terminal The new Windows Terminal. Severity-Blocking We won't ship a release like this! No-siree. Priority-1 A description (P1) labels Nov 7, 2020
@DHowett DHowett added this to the Terminal v1.5 milestone Nov 7, 2020
@ghost ghost added the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Nov 7, 2020
@Don-Vito
Copy link
Contributor

Don-Vito commented Nov 7, 2020

@DHowett - I am taking a look. I believe this is really somewhere in the integration you mentioned. Sorry.

@Don-Vito
Copy link
Contributor

Don-Vito commented Nov 7, 2020

I believe I found it: I introduced a bug where tabs in palette are also sorted by name. I guess performing tests where all tabs have the same name was a bad idea.

@Don-Vito Don-Vito mentioned this issue Nov 7, 2020
Merged
@ghost ghost added the In-PR This issue has a related PR label Nov 7, 2020
@DHowett
Copy link
Member Author

DHowett commented Nov 7, 2020

No need to apologize! These things happen all the time 😄

@DHowett DHowett removed the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Nov 7, 2020
@DHowett
Copy link
Member Author

DHowett commented Nov 7, 2020

(I've introduced more regressions than I'm entitled to! I personally broke defaultProfile for two whole releases before we realized it. That was a fun one!)

@Don-Vito
Copy link
Contributor

Don-Vito commented Nov 7, 2020

Mine was very basic.. 😿 I added a UT for it, and I would like to add much more tests. But my main gap / concern is that adding more tests will result in even more CI instability. There is a lot of async logic when testing UI, I've seen some attempts to handle this with Sleeps, but this sounds not robust enough.

@ghost ghost closed this as completed in #8188 Nov 9, 2020
@ghost ghost removed the In-PR This issue has a related PR label Nov 9, 2020
ghost pushed a commit that referenced this issue Nov 9, 2020
@Don-Vito
8185: do not sort commands by name in tabswitcher mode (#8188)
c90ecf7 
In introduced a bug in #8185, due to which Command Palette sorts items
alphabetically in the tab switcher mode. This PR fixes it.

Validation:
Created tabs with different names and verified that the MRU order is
preserved

Closes #8185
@ghost ghost added the Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. label Nov 9, 2020
@ghost
Copy link

ghost commented Nov 11, 2020

🎉This issue was addressed in #8188, which has now been successfully released as Windows Terminal Preview v1.5.3142.0.:tada:

Handy links:

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area-User Interface Issues pertaining to the user interface of the Console or Terminal Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-1 A description (P1) Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. Severity-Blocking We won't ship a release like this! No-siree.
Projects
None yet
Milestone
Terminal v1.5
Development

Successfully merging a pull request may close this issue.

8185: do not sort commands by name in tabswitcher mode Don-Vito/terminal
2 participants
@DHowett @Don-Vito