Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make the TabViewItemHeader a custom control #8201

Closed
zadjii-msft opened this issue Nov 9, 2020 · 1 comment · Fixed by #8227
Closed

Make the TabViewItemHeader a custom control #8201

zadjii-msft opened this issue Nov 9, 2020 · 1 comment · Fixed by #8227
Assignees
@PankajBhojwani
Labels
Area-CodeHealth Issues related to code cleanliness, linting, rules, warnings, errors, static analysis, etc. Issue-Task It's a feature request, but it doesn't really need a major design. Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Milestone
Terminal v2.0

Comments

@zadjii-msft
Copy link
Member

We on the team have been discussing this for a while, but I think we need to just bite the bullet on it finally.

We've been hacking things into the TabViewItem's Header for a while now, but we're just constantly doing it at runtime. This is not the best - we probably need to have a custom control for it. This control would include:
@zadjii-msft zadjii-msft added Product-Terminal The new Windows Terminal. Issue-Task It's a feature request, but it doesn't really need a major design. Area-CodeHealth Issues related to code cleanliness, linting, rules, warnings, errors, static analysis, etc. labels Nov 9, 2020
@ghost ghost added the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Nov 9, 2020
@zadjii-msft zadjii-msft mentioned this issue Nov 9, 2020
Merged
@DHowett DHowett added this to the Terminal v2.0 milestone Nov 9, 2020
@DHowett DHowett removed the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Nov 9, 2020
@PankajBhojwani PankajBhojwani self-assigned this Nov 9, 2020
@PankajBhojwani PankajBhojwani mentioned this issue Nov 11, 2020
Merged
@ghost ghost added the In-PR This issue has a related PR label Nov 11, 2020
@ghost ghost closed this as completed in #8227 Nov 20, 2020
@ghost ghost added Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. and removed In-PR This issue has a related PR labels Nov 20, 2020
ghost pushed a commit that referenced this issue Nov 20, 2020
@PankajBhojwani
Make tab header a custom control (#8227)
a77b494 
This PR makes the Header of TabViewItem a custom user control.

## Validation Steps Performed
Manual testing

Closes #8201
mpela81 pushed a commit to mpela81/terminal that referenced this issue Nov 22, 2020
@PankajBhojwani @mpela81
Make tab header a custom control (microsoft#8227)
e895852 
This PR makes the Header of TabViewItem a custom user control.

## Validation Steps Performed
Manual testing

Closes microsoft#8201
@ghost
Copy link

ghost commented Jan 28, 2021

🎉This issue was addressed in #8227, which has now been successfully released as Windows Terminal Preview v1.6.10272.0.:tada:

Handy links:

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@PankajBhojwani PankajBhojwani

Labels
Area-CodeHealth Issues related to code cleanliness, linting, rules, warnings, errors, static analysis, etc. Issue-Task It's a feature request, but it doesn't really need a major design. Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Projects
None yet
Milestone
Terminal v2.0
Development

Successfully merging a pull request may close this issue.

Make tab header a custom control microsoft/terminal
3 participants
@DHowett @zadjii-msft @PankajBhojwani