Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Failed to build the conhost project after 13e058d9 #9128

Closed
skyline75489 opened this issue Feb 12, 2021 · 2 comments · Fixed by #9129
Closed

Failed to build the conhost project after 13e058d9 #9128

skyline75489 opened this issue Feb 12, 2021 · 2 comments · Fixed by #9129
Labels
Needs-Tag-Fix Doesn't match tag requirements Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.

Comments

@skyline75489
Copy link
Collaborator

MSBulid failed with:

src\server\IoDispatchers.cpp(21,10): Error C1083: Cannot open include file: 'IConsoleHandoff.h': No such file or directory

I'm positive that I'm not the first one that noticed this...
@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Feb 12, 2021
@DHowett
Copy link
Member

DHowett commented Feb 12, 2021

You're going to be the first one who noticed this. 😄

@DHowett
Copy link
Member

DHowett commented Feb 12, 2021

@miniksa FYI for tomorrow.

@skyline75489 if you want to try fixing it 😄

DHowett added a commit that referenced this issue Feb 12, 2021
@DHowett
Fix the Host Proxy DLL reference in ServerLib
ed5b3d6 
Fixes #9128
@DHowett DHowett mentioned this issue Feb 12, 2021
Merged
@ghost ghost added the In-PR This issue has a related PR label Feb 12, 2021
@ghost ghost closed this as completed in #9129 Feb 12, 2021
@ghost ghost removed the In-PR This issue has a related PR label Feb 12, 2021
ghost pushed a commit that referenced this issue Feb 12, 2021
@DHowett
Fix the Host Proxy DLL reference in ServerLib (#9129)
604eaf9 
Fixes #9128
@ghost ghost added the Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. label Feb 12, 2021
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Needs-Tag-Fix Doesn't match tag requirements Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix the Host Proxy DLL reference in ServerLib microsoft/terminal
2 participants
@DHowett @skyline75489