Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Represent Cursor Height as a slider #9377

Closed
carlos-zamora opened this issue Mar 4, 2021 · 1 comment · Fixed by #9386
Closed

Represent Cursor Height as a slider #9377

carlos-zamora opened this issue Mar 4, 2021 · 1 comment · Fixed by #9386
Labels
Area-Settings UI Anything specific to the SUI good first issue This is a fix that might be easier for someone to do as a first contribution Issue-Task It's a feature request, but it doesn't really need a major design. Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Milestone
Terminal v1.8

Comments

@carlos-zamora
Copy link
Member

Follow-up to #9370. Now that this setting has a minimum/maximum value, we should represent it as a slider.

Take a look at how we handle other sliders in the setting UI. Should be fairly straightforward.
@carlos-zamora carlos-zamora added Product-Terminal The new Windows Terminal. Issue-Task It's a feature request, but it doesn't really need a major design. good first issue This is a fix that might be easier for someone to do as a first contribution Area-Settings UI Anything specific to the SUI labels Mar 4, 2021
@carlos-zamora carlos-zamora added this to the Terminal v1.8 milestone Mar 4, 2021
@ghost ghost added the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Mar 4, 2021
@eugenesmlv eugenesmlv mentioned this issue Mar 4, 2021
Closed
6 tasks
@ghost ghost added In-PR This issue has a related PR and removed In-PR This issue has a related PR labels Mar 4, 2021
@eugenesmlv eugenesmlv mentioned this issue Mar 5, 2021
Merged
5 tasks
@ghost ghost added the In-PR This issue has a related PR label Mar 5, 2021
@ghost ghost closed this as completed in #9386 Mar 9, 2021
@ghost ghost added Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. and removed In-PR This issue has a related PR labels Mar 9, 2021
ghost pushed a commit that referenced this issue Mar 9, 2021
@eugenesmlv
[Settings UI] Represent Cursor Height as a slider (#9386)
48d59e8 
Change the vintage cursor height number box to a slider.

## References
Related:  #9370

## PR Checklist
* [x] Closes #9377
* [x] zadjii-msft edit: Now _this one_ closes #9175
* [x] CLA signed. If not, go over [here](https://cla.opensource.microsoft.com/microsoft/Terminal) and sign the CLA
* [x] Schema updated.
* [ ] 

## Detailed Description of the Pull Request / Additional comments

It seems like the cursor height couldn't be lower than 25 percent regardless of the given value, so I've changed the `MinCursorHeightPercent` in CustomTextRenderer header file.

## Validation Steps Performed
Manual validation

![CursorHeightSlider](https://user-images.githubusercontent.com/39456018/110041939-bf076080-7d66-11eb-8d58-ba9a84922803.gif)
@ghost
Copy link

ghost commented Apr 14, 2021

🎉This issue was addressed in #9386, which has now been successfully released as Windows Terminal Preview v1.8.1032.0.:tada:

Handy links:

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area-Settings UI Anything specific to the SUI good first issue This is a fix that might be easier for someone to do as a first contribution Issue-Task It's a feature request, but it doesn't really need a major design. Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Projects
None yet
Milestone
Terminal v1.8
1 participant
@carlos-zamora