-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Throttle the bell sound (and visual indication) to avoid overloading audio stack #9776
Comments
Thanks for the report! I'm not sure how we're tripping over some driver issues, but I think it would be a good idea for us to limit the number of bells we emit (throttle them to 1/second or so?) I'm going to repurpose this issue as the "throttle bells" task. I hope that it'll help! |
<!-- Please review the items on the PR checklist before submitting--> ## PR Checklist * [x] Closes microsoft#9776 * [x] CLA signed. * [ ] Tests added/passed * [ ] Documentation updated. * [ ] Schema updated. * [ ] I've discussed this with core contributors already. ## Detailed Description of the Pull Request / Additional comments Use `ThrottledFunc` in `TermControl` to limit bell emission callback to one per second.
<!-- Please review the items on the PR checklist before submitting--> ## PR Checklist * [x] Closes #9776 * [x] CLA signed. * [ ] Tests added/passed * [ ] Documentation updated. * [ ] Schema updated. * [ ] I've discussed this with core contributors already. ## Detailed Description of the Pull Request / Additional comments Use `ThrottledFunc` in `TermControl` to limit bell emission callback to one per second. (cherry picked from commit 9a2d27e)
🎉This issue was addressed in #9812, which has now been successfully released as Handy links: |
🎉This issue was addressed in #9812, which has now been successfully released as Handy links: |
Windows Terminal version (or Windows build number)
1.6.10571.0
Other Software
Software
NVidia Game Ready Drivers v465.89
Windows Build 19042.867
Hardware
NVidia Geforce GTX 970
I'm using HDMI on the GPU for video and audio
Steps to reproduce
Expected Behavior
Lots of Windows Alert sounds
Actual Behavior
First the sounds will appear normally, but then it's just break down in loud audio glitching / corruption. To get rid of it you'll have to shut down the PC (restarting didn't help in my experience)
The text was updated successfully, but these errors were encountered: