-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix dropdown showing in up direction #10009
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Quick question before signing off. If there isn't enough space below the button, does it open upwards?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seriously, thanks. Wild that this changed.. 😄
Hello @DHowett! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
## Summary of the Pull Request Let the dropdown menu open downwards if there's enough space, when clicking on the down arrow. ## PR Checklist * [X] Closes #8924 * [X] CLA signed. ## Detailed Description of the Pull Request / Additional comments Set the placement of the flyout to BottomEdgeAlignedLeft, as was done when opening the menu from the key binding. ## Validation Steps Performed Manual tests (cherry picked from commit 2b4c20b)
## Summary of the Pull Request Let the dropdown menu open downwards if there's enough space, when clicking on the down arrow. ## PR Checklist * [X] Closes #8924 * [X] CLA signed. ## Detailed Description of the Pull Request / Additional comments Set the placement of the flyout to BottomEdgeAlignedLeft, as was done when opening the menu from the key binding. ## Validation Steps Performed Manual tests (cherry picked from commit 2b4c20b)
🎉 Handy links: |
🎉 Handy links: |
Summary of the Pull Request
Let the dropdown menu open downwards if there's enough space, when clicking on the down arrow.
PR Checklist
Detailed Description of the Pull Request / Additional comments
Set the placement of the flyout to BottomEdgeAlignedLeft, as was done when opening the menu from the key binding.
Validation Steps Performed
Manual tests