Only move the window to the current desktop when it isn't on that one already #10025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ent desktop already
zadjii-msft
added
Issue-Bug
carlos-zamora
approved these changes
May 3, 2021
| // we are, then don't call MoveWindowToDesktop. This is to mitigate | ||
| // MSFT:33035972 | ||
| BOOL onCurrentDesktop{ false }; | ||
| if (SUCCEEDED(_desktopManager->IsWindowOnCurrentVirtualDesktop(_window->GetHandle(), &onCurrentDesktop)) && onCurrentDesktop) |
There was a problem hiding this comment.
FAILED doesn't exist? Or could we do !SUCCEEDED?
I was taught that...
if (x)
// do nothing
else
// do somethingshould always be simplified to...
if (!x)
// do somethingbut otherwise, meh.
There was a problem hiding this comment.
This is more complicated because of the conditional. I'd just leave it.
DHowett
approved these changes
May 4, 2021
DHowett
added
the
AutoMerge
|
Hello @DHowett! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
ghost
merged commit
|
🎉 Handy links: |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
This is to mitigate MSFT:33035972. If you call
MoveWindowToDesktopwhile an app is set to "Show windows from this app on all desktops", the OS will clear that "Show windows from this app on all desktops" state. But it won't clear that state from the task view, so it'll just plain look broken.We can mitigate this just by checking if we're already on the current desktop first. "Show windows from this app on all desktops" windows will always be on every desktop, so that API will return true, and we can avoid tearing the state.
References
desktopparam toglobalSummon; set _quake = toCurrent #9954PR Checklist
Validation Steps Performed