-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WPF] Allows setting the WPF control background when setting the terminal theme #10026
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@DHowett would it be possible to get a release with this change? We'd like to include it in our 16.10 release for this month. |
This fix has existed for ~3 hours -- give it some time 😄 What's your deadline look like? |
I noticed that 1.9 is slated for May 30th, but I'm hoping we can get a release this week or early next? Hopefully I'm not crossing wires by pushing for a release. |
@DHowett, chatted with Tina and we're okay with this shipping with 1.9 at the end of May. So disregard my previous comment. |
Hello @DHowett! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
…inal theme (#10026) When syncing terminals across users (i.e. Liveshare shared terminals), the terminal size is synced. This leads to having unused space around the terminal which is the same color as the terminal's background causing confusion as to what space is usable within the terminal. Instead this change allows consumers to set the background color of the control, separate from the terminal renderer's background, which makes it easier to identify the edges of the terminal. (cherry picked from commit 31414aa)
…inal theme (#10026) When syncing terminals across users (i.e. Liveshare shared terminals), the terminal size is synced. This leads to having unused space around the terminal which is the same color as the terminal's background causing confusion as to what space is usable within the terminal. Instead this change allows consumers to set the background color of the control, separate from the terminal renderer's background, which makes it easier to identify the edges of the terminal. (cherry picked from commit 31414aa)
🎉 Handy links: |
🎉 Handy links: |
When syncing terminals across users (i.e. Liveshare shared terminals),
the terminal size is synced. This leads to having unused space around
the terminal which is the same color as the terminal's background
causing confusion as to what space is usable within the terminal.
Instead this change allows consumers to set the background color of the
control, separate from the terminal renderer's background, which makes
it easier to identify the edges of the terminal.