Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce string operation cost in VtEngine::PaintBufferLine #10567

Closed

Conversation

skyline75489
Copy link
Collaborator

Summary of the Pull Request

References

PR Checklist

  • Supports [Performance] vtebench tracking issue #10563
  • CLA signed. If not, go over here and sign the CLA
  • Tests added/passed
  • Documentation updated. If checked, please file a pull request on our docs repo and link it here: #xxx
  • Schema updated.
  • I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #xxx

Detailed Description of the Pull Request / Additional comments

Validation Steps Performed

@lhecker
Copy link
Member

lhecker commented Jul 6, 2021

I'm not sure if I like this change much...
We could circumvent the entire performance overhead from the get-go by passing the entire console buffer line to this function. What it does now is splitting the console line into clusters, just to reassemble the line later on for VT. This feels very hacky to me and is what I would consider as the underlying issue.

@skyline75489
Copy link
Collaborator Author

skyline75489 commented Jul 6, 2021 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants