Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix alt+space opening system menu and sending keys to terminal #10988

Merged
5 commits merged into from
Aug 24, 2021
Merged

Fix alt+space opening system menu and sending keys to terminal #10988

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
0307728
works
PankajBhojwani Aug 19, 2021
6b68981
comment for clarity
PankajBhojwani Aug 19, 2021
929867d
scancode
PankajBhojwani Aug 20, 2021
859d05e
Merge branch 'main' of https://github.com/microsoft/terminal into dev…
PankajBhojwani Aug 23, 2021
36b0685
mark todo
PankajBhojwani Aug 23, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions src/cascadia/TerminalControl/TermControl.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -903,6 +903,24 @@ namespace winrt::Microsoft::Terminal::Control::implementation
return;
}

if (vkey == VK_SPACE && modifiers.IsAltPressed())
{
if (const auto bindings = _settings.KeyBindings())
{
if (!bindings.IsKeyChordExplicitlyUnbound({ modifiers.IsCtrlPressed(), modifiers.IsAltPressed(), modifiers.IsShiftPressed(), modifiers.IsWinPressed(), vkey, scanCode }))
{
// If we get here, it means that
// 1. we do not have a command bound to alt+space
// 2. alt+space was not explicitly unbound
// That means that XAML handled the alt+space to open up the context menu, and
// so we don't want to send anything to the terminal
// TODO GH#11018: Add a new "openSystemMenu" keybinding
e.Handled(true);
return;
}
}
}

if (_TrySendKeyEvent(vkey, scanCode, modifiers, keyDown))
{
e.Handled(true);
Expand Down