Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a file for storing elevated-only state #11222
Add a file for storing elevated-only state #11222
Changes from 28 commits
6be6972
c106f64
51e0473
da0cc7b
4e69a32
6757452
a4acdeb
5685063
9b3b9e0
507a48e
b1b1bef
7e2e4ea
f3738f5
a6e044d
eee657b
02e9871
5ff9a24
620ee30
d053f6c
866832b
b4e0496
9ff2775
48b20de
3c1866a
aea3752
0e7217d
ae99ce9
bf3c6e7
faa06f8
945c81d
9b4ae9e
4976a09
fd849a5
25b2675
b212871
4f16dfb
a93d17e
ce6a9c5
db9cbf3
08cbd16
999f21f
33e96e7
7f03d4d
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor performance concern -- this allocates an hstring (another copy) for every file that is ever changed in this folder. Is there something we can do to not do that?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Eventually we'll have to pass the path to
ApplicationState::IsStatePath(...)
, which would need to take thehstring
, since that lives in TSM.dll.We could break the encapsulation and have
AppLogic
know what the app state paths are. Alternatively, we could not really worry about someone writing to a bunch of files in this directory in rapid succession like a madman 🤔There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should use
.native()
more liberally onstd::filesystem::path
s. It returns a constant reference to the underlying wide string for free.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You don't need to construct a hstring to pass it to a COM call. All std strings implicitly convert to
winrt::param::hstring
.