Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused rendering settings from profile #11685

Merged
merged 1 commit into from
Nov 4, 2021

Conversation

PankajBhojwani
Copy link
Contributor

@PankajBhojwani PankajBhojwani commented Nov 4, 2021

The ForceFullRepaintRendering and SoftwareRendering are global only and for some reason were in profile. This commit removes them.

Reference: #11416 (comment)

Copy link
Member

@DHowett DHowett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let me guess: these failed to build because of the _OpenSettingsUI thing?

@DHowett
Copy link
Member

DHowett commented Nov 4, 2021

Build log confirms -- Terminal.Settings.Model.dll still builds. I'm admin-merging this to avoid another signoff cycle./

@DHowett DHowett changed the title Remove rendering settings from profile Remove unused rendering settings from profile Nov 4, 2021
@DHowett DHowett merged commit 761203d into main Nov 4, 2021
@DHowett DHowett deleted the dev/pabhoj/profile_rendering_settings branch November 4, 2021 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants