Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix length calculation of GetConsoleCommandHistoryLengthA #11897

Merged
merged 1 commit into from
Dec 7, 2021
Merged

Fix length calculation of GetConsoleCommandHistoryLengthA #11897

merged 1 commit into from
Dec 7, 2021

Conversation

lhecker
Copy link
Member

@lhecker lhecker commented Dec 7, 2021 •
edited
Loading

This is a primitive bug fix for GetConsoleCommandHistoryLengthA.

PR Checklist

  • I work here
  • Tests added/passed

@lhecker lhecker requested a review from miniksa December 7, 2021 17:51
zadjii-msft
zadjii-msft approved these changes Dec 7, 2021
View reviewed changes
Copy link
Member

@zadjii-msft zadjii-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maintain the ASCII API in the first place

s/ASCII/GetConsoleCommandHistoryLength/

@zadjii-msft zadjii-msft added the AutoMerge Marked for automatic merge by the bot when requirements are met label Dec 7, 2021
@ghost
Copy link

ghost commented Dec 7, 2021

Hello @zadjii-msft!

Because this pull request has the AutoMerge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

Do note that I've been instructed to only help merge pull requests of this repository that have been opened for at least 8 hours, a condition that will be fulfilled in about 7 hours 54 minutes. No worries though, I will be back when the time is right! 😉

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@lhecker
Copy link
Member Author

lhecker commented Dec 7, 2021

s/ASCII/GetConsoleCommandHistoryLength/

Yeah let me remove that. 😄 Although we could realistically remove the entire ASCII apiset for private APIs like that one and remove a ton of legacy code in one swoop without breaking anything.

@lhecker lhecker merged commit ca20bbd into main Dec 7, 2021
@lhecker lhecker deleted the dev/lhecker/GetConsoleCommandHistoryLengthA branch December 7, 2021 19:04
@lhecker lhecker added Area-Server Down in the muck of API call servicing, interprocess communication, eventing, etc. Issue-Bug It either shouldn't be doing this or needs an investigation. labels Dec 7, 2021
DHowett pushed a commit that referenced this pull request Dec 13, 2021
@lhecker @DHowett
Fix length calculation of GetConsoleCommandHistoryLengthA (#11897)
c6626bd 
This is a primitive bug fix for GetConsoleCommandHistoryLengthA.

## PR Checklist
* [x] I work here
* [x] Tests added/passed

(cherry picked from commit ca20bbd)
DHowett pushed a commit that referenced this pull request Dec 13, 2021
@lhecker @DHowett
Fix length calculation of GetConsoleCommandHistoryLengthA (#11897)
e0c4277 
This is a primitive bug fix for GetConsoleCommandHistoryLengthA.

## PR Checklist
* [x] I work here
* [x] Tests added/passed

(cherry picked from commit ca20bbd)
@ghost
Copy link

ghost commented Dec 14, 2021

🎉Windows Terminal Preview v1.12.3472.0 has been released which incorporates this pull request.:tada:

Handy links:

@ghost
Copy link

ghost commented Dec 14, 2021

🎉Windows Terminal v1.11.3471.0 has been released which incorporates this pull request.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miniksa miniksa miniksa approved these changes

@zadjii-msft zadjii-msft zadjii-msft approved these changes

Assignees
No one assigned
Labels
Area-Server Down in the muck of API call servicing, interprocess communication, eventing, etc. AutoMerge Marked for automatic merge by the bot when requirements are met Issue-Bug It either shouldn't be doing this or needs an investigation.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lhecker @miniksa @zadjii-msft