Replace GetDefaultBrushColors with hardcoded default attributes

src/cascadia/PublicTerminalCore/HwndTerminal.cpp

@@ -883,7 +883,7 @@ try
         {
             const auto& fontData = _actualFont;
             int const iFontHeightPoints = fontData.GetUnscaledSize().Y; // this renderer uses points already
-            const COLORREF bgColor = _terminal->GetAttributeColors(_terminal->GetDefaultBrushColors()).second;
+            const COLORREF bgColor = _terminal->GetAttributeColors({}).second;
 
             std::string HTMLToPlaceOnClip = TextBuffer::GenHTML(rows, iFontHeightPoints, fontData.GetFaceName(), bgColor);
             _CopyToSystemClipboard(HTMLToPlaceOnClip, L"HTML Format");

src/cascadia/TerminalCore/Terminal.hpp

@@ -164,7 +164,6 @@ class Microsoft::Terminal::Core::Terminal final :
 
 #pragma region IRenderData
     // These methods are defined in TerminalRenderData.cpp
-    const TextAttribute GetDefaultBrushColors() noexcept override;
     COORD GetCursorPosition() const noexcept override;
     bool IsCursorVisible() const noexcept override;
     bool IsCursorOn() const noexcept override;

src/cascadia/TerminalCore/terminalrenderdata.cpp

@@ -42,11 +42,6 @@ void Terminal::SetFontInfo(const FontInfo& fontInfo)
     _fontInfo = fontInfo;
 }
 
-const TextAttribute Terminal::GetDefaultBrushColors() noexcept
-{
-    return TextAttribute{};
-}
-
 std::pair<COLORREF, COLORREF> Terminal::GetAttributeColors(const TextAttribute& attr) const noexcept
 {
     std::pair<COLORREF, COLORREF> colors;

src/host/renderData.cpp

@@ -102,17 +102,6 @@ void RenderData::UnlockConsole() noexcept
 #pragma endregion
 
 #pragma region IRenderData
-// Routine Description:
-// - Retrieves the brush colors that should be used in absence of any other color data from
-//   cells in the text buffer.
-// Return Value:
-// - TextAttribute containing the foreground and background brush color data.
-const TextAttribute RenderData::GetDefaultBrushColors() noexcept
-{
-    const CONSOLE_INFORMATION& gci = ServiceLocator::LocateGlobals().getConsoleInformation();
-    return gci.GetActiveOutputBuffer().GetAttributes();
-}
-
 // Method Description:
 // - Gets the cursor's position in the buffer, relative to the buffer origin.
 // Arguments:

src/host/renderData.hpp

@@ -37,8 +37,6 @@ class RenderData final :
 #pragma endregion
 
 #pragma region IRenderData
-    const TextAttribute GetDefaultBrushColors() noexcept override;
-
     COORD GetCursorPosition() const noexcept override;
     bool IsCursorVisible() const noexcept override;
     bool IsCursorOn() const noexcept override;

src/host/ut_host/VtIoTests.cpp

@@ -290,11 +290,6 @@ class MockRenderData : public IRenderData, IUiaData
     {
     }
 
-    const TextAttribute GetDefaultBrushColors() noexcept override
-    {
-        return TextAttribute{};
-    }
-
     std::pair<COLORREF, COLORREF> GetAttributeColors(const TextAttribute& /*attr*/) const noexcept override
     {
         return std::make_pair(COLORREF{}, COLORREF{});

src/renderer/base/renderer.cpp

@@ -142,7 +142,7 @@ try
     });
 
     // A. Prep Colors
-    RETURN_IF_FAILED(_UpdateDrawingBrushes(pEngine, _pData->GetDefaultBrushColors(), false, true));
+    RETURN_IF_FAILED(_UpdateDrawingBrushes(pEngine, {}, false, true));
 
     // B. Perform Scroll Operations
     RETURN_IF_FAILED(_PerformScrolling(pEngine));

src/renderer/inc/IRenderData.hpp

@@ -46,8 +46,6 @@ namespace Microsoft::Console::Render
         IRenderData& operator=(const IRenderData&) = default;
         IRenderData& operator=(IRenderData&&) = default;
 
-        virtual const TextAttribute GetDefaultBrushColors() noexcept = 0;
-
         virtual COORD GetCursorPosition() const noexcept = 0;
         virtual bool IsCursorVisible() const noexcept = 0;
         virtual bool IsCursorOn() const noexcept = 0;