-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update the tab colors some more #12635
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zadjii-msft
added
Area-User Interface
Issues pertaining to the user interface of the Console or Terminal
Product-Terminal
The new Windows Terminal.
zPreview-Service-Queued-1.13
A floating label that tracks the current Preview version for servicing purposes.
labels
Mar 7, 2022
lhecker
approved these changes
Mar 7, 2022
DHowett
approved these changes
Mar 9, 2022
how it look in light? |
DHowett
added
the
AutoMerge
Marked for automatic merge by the bot when requirements are met
label
Mar 9, 2022
Hello @DHowett! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
ghost
deleted the
dev/migrie/b/12400-MORE-color-nits
branch
March 9, 2022 23:53
DHowett
pushed a commit
that referenced
this pull request
Mar 10, 2022
Again, to reflect continuing discussion with the WinUI team. A doc may have been misread - these are the colors they're proposing, which are generally a lot better. See also: #12400, #12356, #12398 ![image](https://user-images.githubusercontent.com/18356694/157041174-c0eb2140-3b49-4494-8746-b3a12f396fe6.png) (cherry picked from commit aaa3ee7)
zadjii-msft
added a commit
that referenced
this pull request
Mar 10, 2022
Again, to reflect continuing discussion with the WinUI team. A doc may have been misread - these are the colors they're proposing, which are generally a lot better. See also: #12400, #12356, #12398 ![image](https://user-images.githubusercontent.com/18356694/157041174-c0eb2140-3b49-4494-8746-b3a12f396fe6.png)
🎉 Handy links: |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Area-User Interface
Issues pertaining to the user interface of the Console or Terminal
AutoMerge
Marked for automatic merge by the bot when requirements are met
Product-Terminal
The new Windows Terminal.
zPreview-Service-Queued-1.13
A floating label that tracks the current Preview version for servicing purposes.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Again, to reflect continuing discussion with the WinUI team. A doc may have been misread - these are the colors they're proposing, which are generally a lot better.
See also: #12400, #12356, #12398