Re-add support for Mica, transparent titlebars #13935

zadjii-msft · 2022-09-06T21:11:17Z

This reverts commit 19b6d35.

This re-enables support for Mica, and transparent titlebars in general. It also syncs the titlebar opacity with the control opacity for terminalBackground. It also somehow fixes the bug where the bottom few pixels of the max btn doesn't work to trigger the snap flyout.

Closes #10509

Does nothing for #13631

To-done's

Check the mica API on 22000, windows 11 RTM
- this works on 10.0.22621.674, but that's not 22000
Check how this behaves on windows 10.
- For both, this API just no-ops. That's fine! we can just say "Mica is only supported on >=22621"

This reverts commit 19b6d35.

…s really matters.

…ent-tab-row-002

carlos-zamora

Approving but I'm trusting you to get these done too haha:

schema
docs (especially mention that bit on tabRow.background needing to be transparent like #00000000)

DHowett · 2022-12-08T01:48:29Z

Nit: please remove the TODO section from your commit body before you merge.

src/cascadia/WindowsTerminal/AppHost.cpp

DHowett · 2022-12-08T01:51:59Z

src/cascadia/WindowsTerminal/NonClientIslandWindow.cpp

+        // Make sure to trim the right side of the rectangle, so that it doesn't
+        // hang off the right side of the root window. This normally wouldn't
+        // matter, but UIA will still think its bounds can extend past the right
+        // of the parent HWND.


Whoa, what does THIS fix?

Is this the thing that does nothing for 13631? Should we revert it since it does nothing?

It doesn't do nothing - it actually makes the UIA bounding box sane, rather than hanging way off the edge of the window.

I can pull that into a separate PR if you want.

src/cascadia/WindowsTerminal/NonClientIslandWindow.cpp

…ent-tab-row-002

…ning nits.

DHowett

I'm OK with this! Thanks for doing all the testing! LET'S GOOO

ghost · 2022-12-09T20:50:46Z

Hello @zadjii-msft!

Because this pull request has the AutoMerge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (`@msftbot`) and give me an instruction to get started! Learn more here.

ghost · 2023-01-24T18:22:49Z

🎉Windows Terminal Preview v1.17.1023 has been released which incorporates this pull request.:tada:

Handy links:

Documents a whole pile of stuff from 1.17: * `useMica` microsoft/terminal#13935 * theme pairs microsoft/terminal#14497 * scheme pairs microsoft/terminal#14064 * closes #626

* fix(powerline): update oh-my-posh CLI (#632) * Themes updates for 1.17 (#634) Documents a whole pile of stuff from 1.17: * `useMica` microsoft/terminal#13935 * theme pairs microsoft/terminal#14497 * scheme pairs microsoft/terminal#14064 * closes #626 * Default prompt icon info, resolves #625 (#642) * Add app execution alias section (#643) * Add autoHideWindows Resolves #633 * Add color theme FAQs * Remove code brackets from headers Resolves #637 * Fix default if no command specified Called out in #638 * Add note differentiating null from no setting for Starting Directory. Resolves #624 --------- Co-authored-by: Jan De Dobbeleer <2492783+JanDeDobbeleer@users.noreply.github.com> Co-authored-by: Mike Griese <migrie@microsoft.com>

* fix(powerline): update oh-my-posh CLI (#632) * Themes updates for 1.17 (#634) Documents a whole pile of stuff from 1.17: * `useMica` microsoft/terminal#13935 * theme pairs microsoft/terminal#14497 * scheme pairs microsoft/terminal#14064 * closes #626 * Default prompt icon info, resolves #625 (#642) * Add app execution alias section (#643) * Add autoHideWindows Resolves #633 * Add color theme FAQs * Remove code brackets from headers Resolves #637 * Fix default if no command specified Called out in #638 * Add note differentiating null from no setting for Starting Directory. Resolves #624 * add the adobe-target metadata for A/B testing (#646) could you please help to merge this metadata change (adobe-target=true) to main branch and then to live? This is to enable A/B testing ability across many url base paths so we can improve Learn user experience based on data-driven decisions. This meta (adobe-target) itself will not change how your content is displayed or modify any other UI behaviors so it is safe to merge. --------- Co-authored-by: Jan De Dobbeleer <2492783+JanDeDobbeleer@users.noreply.github.com> Co-authored-by: Mike Griese <migrie@microsoft.com> Co-authored-by: Matt Wojciakowski <mattwoj@microsoft.com>

* fix(powerline): update oh-my-posh CLI (#632) * Themes updates for 1.17 (#634) Documents a whole pile of stuff from 1.17: * `useMica` microsoft/terminal#13935 * theme pairs microsoft/terminal#14497 * scheme pairs microsoft/terminal#14064 * closes #626 * Default prompt icon info, resolves #625 (#642) * Add app execution alias section (#643) * Add autoHideWindows Resolves #633 * Add color theme FAQs * Remove code brackets from headers Resolves #637 * Fix default if no command specified Called out in #638 * Add note differentiating null from no setting for Starting Directory. Resolves #624 * add the adobe-target metadata for A/B testing (#646) could you please help to merge this metadata change (adobe-target=true) to main branch and then to live? This is to enable A/B testing ability across many url base paths so we can improve Learn user experience based on data-driven decisions. This meta (adobe-target) itself will not change how your content is displayed or modify any other UI behaviors so it is safe to merge. * Add documentation to include information about enable/disable read-only mode functionality (#645) * Update actions to include new enable and disable functionality * Update panes to include new enable and disable functionality * Many updates to commandline args docs, and some missing actions too (#649) * Many updates to commandline args docs, and some missing actions too * Fix anchor link warnings --------- Co-authored-by: Matt Wojciakowski <mattwoj@microsoft.com> * Remove Dynamic SSH profiles from doc since it has not been implemente… (#650) * Remove Dynamic SSH profiles from doc since it has not been implemented yet. * Updated authors and date * Shelfing read-only mode docs until it goes in a future release (#653) * Added maximum history size (#657) * added maximum history size * empty commit to poke the bot * remove instances of Preview for 1.15 features (#669) * remove enableReadOnlyMode and disableReadyOnlyMode docs in panes until it goes live in a future release (#672) --------- Co-authored-by: Jan De Dobbeleer <2492783+JanDeDobbeleer@users.noreply.github.com> Co-authored-by: Mike Griese <migrie@microsoft.com> Co-authored-by: Matt Wojciakowski <mattwoj@microsoft.com> Co-authored-by: juchen-ms <partychen.acm@gmail.com> Co-authored-by: Alex Noble <6237394+Swinkid@users.noreply.github.com>

* fix(powerline): update oh-my-posh CLI (#632) * Themes updates for 1.17 (#634) Documents a whole pile of stuff from 1.17: * `useMica` microsoft/terminal#13935 * theme pairs microsoft/terminal#14497 * scheme pairs microsoft/terminal#14064 * closes #626 * Default prompt icon info, resolves #625 (#642) * Add app execution alias section (#643) * Add autoHideWindows Resolves #633 * Add color theme FAQs * Remove code brackets from headers Resolves #637 * Fix default if no command specified Called out in #638 * Add note differentiating null from no setting for Starting Directory. Resolves #624 * add the adobe-target metadata for A/B testing (#646) could you please help to merge this metadata change (adobe-target=true) to main branch and then to live? This is to enable A/B testing ability across many url base paths so we can improve Learn user experience based on data-driven decisions. This meta (adobe-target) itself will not change how your content is displayed or modify any other UI behaviors so it is safe to merge. * Add documentation to include information about enable/disable read-only mode functionality (#645) * Update actions to include new enable and disable functionality * Update panes to include new enable and disable functionality * Many updates to commandline args docs, and some missing actions too (#649) * Many updates to commandline args docs, and some missing actions too * Fix anchor link warnings --------- Co-authored-by: Matt Wojciakowski <mattwoj@microsoft.com> * Remove Dynamic SSH profiles from doc since it has not been implemente… (#650) * Remove Dynamic SSH profiles from doc since it has not been implemented yet. * Updated authors and date * Shelfing read-only mode docs until it goes in a future release (#653) * Added maximum history size (#657) * added maximum history size * empty commit to poke the bot * remove instances of Preview for 1.15 features (#669) * remove enableReadOnlyMode and disableReadyOnlyMode docs in panes until it goes live in a future release (#672) * Update Docs with Release 1.18 (#674) * Stashed dynamic SSH profiles doc * Add portable mode docs to release branch 1.18 (#655) * added first draft of docs * changed headings and subheadings * Reword, add an Upgrading section --------- Co-authored-by: Dustin Howett <duhowett@microsoft.com> * Retool the portable mode documentation to explain our distributions (#656) * Retool portable mode to be 'distributions' * Fix warnings * add preinstallation to the feature matrix * add dci to matrix * reword * couple more notes * better version note * Use a data matrix table, re-alt-text the portable mode image * add distributions to the toc * address L's feedbacc * Document 'activeOnly' value for 'showCloseButton' property. (#660) * Shelfing read-only mode docs until it goes in a future release (#653) * Added maximum history size (#657) * added maximum history size * empty commit to poke the bot * Document 'activeOnly' value for 'showCloseButton' property. --------- Co-authored-by: Christopher Nguyen <91625426+nguyen-dows@users.noreply.github.com> * Add a small section on tab tearout in the overview page (#666) * Shelfing read-only mode docs until it goes in a future release (#653) * Added maximum history size (#657) * added maximum history size * empty commit to poke the bot * initial commit * added preview links and small grammatical fixes * added important preview flag * moved Important flag to the end of the section to fit Actions docs * omit unrelated changes that got pulled in from master * omit actions and profiles changes * Add preview text and re-add missing enableReadOnlyMode docs (#673) * add preview text and readd enableReadOnlyMode that was lost in the most recent commit * add preview text for activeOnly value in showCloseButton property docs --------- Co-authored-by: Dustin Howett <duhowett@microsoft.com> Co-authored-by: kovdu <koen.vandurme@gmail.com> --------- Co-authored-by: Jan De Dobbeleer <2492783+JanDeDobbeleer@users.noreply.github.com> Co-authored-by: Mike Griese <migrie@microsoft.com> Co-authored-by: Matt Wojciakowski <mattwoj@microsoft.com> Co-authored-by: juchen-ms <partychen.acm@gmail.com> Co-authored-by: Alex Noble <6237394+Swinkid@users.noreply.github.com> Co-authored-by: Dustin Howett <duhowett@microsoft.com> Co-authored-by: kovdu <koen.vandurme@gmail.com>

…ocs (#678) * fix(powerline): update oh-my-posh CLI (#632) * Themes updates for 1.17 (#634) Documents a whole pile of stuff from 1.17: * `useMica` microsoft/terminal#13935 * theme pairs microsoft/terminal#14497 * scheme pairs microsoft/terminal#14064 * closes #626 * Default prompt icon info, resolves #625 (#642) * Add app execution alias section (#643) * Add autoHideWindows Resolves #633 * Add color theme FAQs * Remove code brackets from headers Resolves #637 * Fix default if no command specified Called out in #638 * Add note differentiating null from no setting for Starting Directory. Resolves #624 * add the adobe-target metadata for A/B testing (#646) could you please help to merge this metadata change (adobe-target=true) to main branch and then to live? This is to enable A/B testing ability across many url base paths so we can improve Learn user experience based on data-driven decisions. This meta (adobe-target) itself will not change how your content is displayed or modify any other UI behaviors so it is safe to merge. * Add documentation to include information about enable/disable read-only mode functionality (#645) * Update actions to include new enable and disable functionality * Update panes to include new enable and disable functionality * Many updates to commandline args docs, and some missing actions too (#649) * Many updates to commandline args docs, and some missing actions too * Fix anchor link warnings --------- Co-authored-by: Matt Wojciakowski <mattwoj@microsoft.com> * Remove Dynamic SSH profiles from doc since it has not been implemente… (#650) * Remove Dynamic SSH profiles from doc since it has not been implemented yet. * Updated authors and date * Shelfing read-only mode docs until it goes in a future release (#653) * Added maximum history size (#657) * added maximum history size * empty commit to poke the bot * remove instances of Preview for 1.15 features (#669) * remove enableReadOnlyMode and disableReadyOnlyMode docs in panes until it goes live in a future release (#672) * Update Docs with Release 1.18 (#674) * Stashed dynamic SSH profiles doc * Add portable mode docs to release branch 1.18 (#655) * added first draft of docs * changed headings and subheadings * Reword, add an Upgrading section --------- Co-authored-by: Dustin Howett <duhowett@microsoft.com> * Retool the portable mode documentation to explain our distributions (#656) * Retool portable mode to be 'distributions' * Fix warnings * add preinstallation to the feature matrix * add dci to matrix * reword * couple more notes * better version note * Use a data matrix table, re-alt-text the portable mode image * add distributions to the toc * address L's feedbacc * Document 'activeOnly' value for 'showCloseButton' property. (#660) * Shelfing read-only mode docs until it goes in a future release (#653) * Added maximum history size (#657) * added maximum history size * empty commit to poke the bot * Document 'activeOnly' value for 'showCloseButton' property. --------- Co-authored-by: Christopher Nguyen <91625426+nguyen-dows@users.noreply.github.com> * Add a small section on tab tearout in the overview page (#666) * Shelfing read-only mode docs until it goes in a future release (#653) * Added maximum history size (#657) * added maximum history size * empty commit to poke the bot * initial commit * added preview links and small grammatical fixes * added important preview flag * moved Important flag to the end of the section to fit Actions docs * omit unrelated changes that got pulled in from master * omit actions and profiles changes * Add preview text and re-add missing enableReadOnlyMode docs (#673) * add preview text and readd enableReadOnlyMode that was lost in the most recent commit * add preview text for activeOnly value in showCloseButton property docs --------- Co-authored-by: Dustin Howett <duhowett@microsoft.com> Co-authored-by: kovdu <koen.vandurme@gmail.com> * Add a tutorial for enabling shell integration (#676) * it's basically just the blog post * fix urls * Right-click context menu, allowHeadless docs (#677) * right-click context menu docs * allowHeadless too while I'm here --------- Co-authored-by: Jan De Dobbeleer <2492783+JanDeDobbeleer@users.noreply.github.com> Co-authored-by: Mike Griese <migrie@microsoft.com> Co-authored-by: Matt Wojciakowski <mattwoj@microsoft.com> Co-authored-by: juchen-ms <partychen.acm@gmail.com> Co-authored-by: Alex Noble <6237394+Swinkid@users.noreply.github.com> Co-authored-by: Dustin Howett <duhowett@microsoft.com> Co-authored-by: kovdu <koen.vandurme@gmail.com>

zadjii-msft added 7 commits September 6, 2022 06:34

Revert "Remove the useMica key (#13872)"

8c3c8fe

This reverts commit 19b6d35.

Clip the drag rect to the right side of the window. I don't think thi…

0a3a537

…s really matters.

add support for transparent titlebars back, for testing.

2fcc420

hey this works - let's clean it up and figure out what is/n't important

337c5e9

Add better support in the Theme objects themselves for transparency

c77173b

way easier

df6d4cd

notes, mostly

2895a34

ghost added Area-Theming Anything related to the theming of elements of the window Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. Product-Terminal The new Windows Terminal. labels Sep 6, 2022

This was referenced Sep 8, 2022

Titlebar rendering bug when mousing over window buttons #13904

Open

UI Suggestion: Visually link tab to console view #702

Closed

zadjii-msft added 2 commits November 2, 2022 15:57

Merge branch 'main' into dev/migrie/f/transparent-tab-row-002

c42965e

hey, we can use the real api now

e9f8569

zadjii-msft marked this pull request as ready for review November 3, 2022 20:15

lhecker approved these changes Nov 4, 2022

View reviewed changes

zadjii-msft mentioned this pull request Nov 14, 2022

Tab bar flickering randomly on both stable and preview version #14384

Open

zadjii-msft and others added 3 commits November 14, 2022 10:02

Merge remote-tracking branch 'origin/main' into dev/migrie/f/transpar…

4964d8b

…ent-tab-row-002

runformat

9058c41

Migrate spelling-0.0.21 changes from main

28cf394

zadjii-msft added the Needs-Second It's a PR that needs another sign-off label Nov 14, 2022

ghost requested review from PankajBhojwani, carlos-zamora and DHowett November 14, 2022 16:05

This comment has been minimized.

Sign in to view

Merge remote-tracking branch 'origin/main' into dev/migrie/f/transpar…

816c249

…ent-tab-row-002

This comment has been minimized.

Sign in to view

zadjii-msft added 3 commits December 1, 2022 10:32

Merge remote-tracking branch 'origin/main' into dev/migrie/f/transpar…

74cf07e

…ent-tab-row-002

REAALLY

28a718a

uhg

c652e95

zadjii-msft added the zBugBash-Consider label Dec 6, 2022

carlos-zamora approved these changes Dec 7, 2022

View reviewed changes

carlos-zamora removed the Needs-Second It's a PR that needs another sign-off label Dec 7, 2022

carlos-zamora assigned zadjii-msft Dec 7, 2022

DHowett requested changes Dec 8, 2022

View reviewed changes

ghost added the Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something label Dec 8, 2022

Merge remote-tracking branch 'origin/main' into dev/migrie/f/transpar…

a22f433

…ent-tab-row-002

ghost removed the Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something label Dec 8, 2022

zadjii-msft added 3 commits December 8, 2022 10:56

THIS WONT WORK Don't blow away titlebar This should satisfy the remai…

976688a

…ning nits.

also, account for how transparent a titlebar might be

6dd6726

runformat

2b00052

zadjii-msft assigned DHowett and unassigned zadjii-msft Dec 9, 2022

DHowett approved these changes Dec 9, 2022

View reviewed changes

zadjii-msft added the AutoMerge Marked for automatic merge by the bot when requirements are met label Dec 9, 2022

ghost merged commit 031271f into main Dec 9, 2022

ghost deleted the dev/migrie/f/transparent-tab-row-002 branch December 9, 2022 20:52

zadjii-msft mentioned this pull request Dec 15, 2022

[1.17] Setting the $theme.tabRow.background to #00000000 results in double titlebar #14563

Closed

ghost mentioned this pull request Jan 24, 2023

Add support for the Mica material #10509

Closed

zadjii-msft mentioned this pull request Jan 24, 2023

Themes updates for 1.17 MicrosoftDocs/terminal#634

Merged

zadjii-msft mentioned this pull request Mar 20, 2023

Changing the title bar color in accordance with the terminal's background. #3774

Closed

This pull request was closed.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Re-add support for Mica, transparent titlebars #13935

Re-add support for Mica, transparent titlebars #13935

zadjii-msft commented Sep 6, 2022 •

edited

Loading

This comment has been minimized.

This comment has been minimized.

carlos-zamora left a comment

DHowett commented Dec 8, 2022 •

edited

Loading

DHowett Dec 8, 2022

DHowett Dec 8, 2022

zadjii-msft Dec 8, 2022

zadjii-msft Dec 8, 2022

DHowett left a comment

ghost commented Dec 9, 2022

ghost commented Jan 24, 2023

Re-add support for Mica, transparent titlebars #13935

Re-add support for Mica, transparent titlebars #13935

Conversation

zadjii-msft commented Sep 6, 2022 • edited Loading

To-done's

This comment has been minimized.

This comment has been minimized.

carlos-zamora left a comment

Choose a reason for hiding this comment

DHowett commented Dec 8, 2022 • edited Loading

DHowett Dec 8, 2022

Choose a reason for hiding this comment

DHowett Dec 8, 2022

Choose a reason for hiding this comment

zadjii-msft Dec 8, 2022

Choose a reason for hiding this comment

zadjii-msft Dec 8, 2022

Choose a reason for hiding this comment

DHowett left a comment

Choose a reason for hiding this comment

ghost commented Dec 9, 2022

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

ghost commented Jan 24, 2023

zadjii-msft commented Sep 6, 2022 •

edited

Loading

DHowett commented Dec 8, 2022 •

edited

Loading

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (`@msftbot`) and give me an instruction to get started! Learn more here.