Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Launch elevated instances via shell:AppFolder #14637

Merged
9 commits merged into from
Jan 19, 2023
Merged

Launch elevated instances via shell:AppFolder #14637

9 commits merged into from
Jan 19, 2023

Commits on Jan 5, 2023

  1. Launch elevated instances via shell:AppFolder 

    Fixes microsoft#14501

This uses `shell:AppsFolder` to launch elevated instances of the app via
`ShellExecuteEx` and `runas` in elevate-shim.exe. The app to launch is
discovered via the `GetCurrentApplicationUserModelId` API.

e.g. `shell:AppsFolder\WindowsTerminalDev_8wekyb3d8bbwe!App`

This will fallback to launching `WindowsTerminal.exe` if it fails to
discover the app user model id to launch.

This also fixes an innocuous bug in elevate-shim where the first
argument of WinMain was lost (e.g. `new-tab`).
    @jboelter
    jboelter committed Jan 5, 2023
    Configuration menu
    Copy the full SHA
    62017c0 View commit details
    Browse the repository at this point in the history

  2. length() -> size()

    @jboelter
    jboelter committed Jan 5, 2023
    Configuration menu
    Copy the full SHA
    145dd52 View commit details
    Browse the repository at this point in the history

  3. make spell check happy

    @jboelter
    jboelter committed Jan 5, 2023
    Configuration menu
    Copy the full SHA
    039307f View commit details
    Browse the repository at this point in the history

  4. make argc const to satisfy audit mode build

    @jboelter
    jboelter committed Jan 5, 2023
    Configuration menu
    Copy the full SHA
    9c794e6 View commit details
    Browse the repository at this point in the history

  5. add wargv to recognized words

    @jboelter
    jboelter committed Jan 5, 2023
    Configuration menu
    Copy the full SHA
    f69a69e View commit details
    Browse the repository at this point in the history

Commits on Jan 7, 2023

  1. Minimized scope of changes and use WIL 

    Reverts the changes to AppLogic.*
Minimizes scope of changes to TerminalPage and elevate-shim
Use WIL for logging and win32 api interaction
    @jboelter
    jboelter committed Jan 7, 2023
    Configuration menu
    Copy the full SHA
    74c4b0c View commit details
    Browse the repository at this point in the history

  2. fix spelling

    @jboelter
    jboelter committed Jan 7, 2023
    Configuration menu
    Copy the full SHA
    1aa94bb View commit details
    Browse the repository at this point in the history

Commits on Jan 12, 2023

  1. simplification to only change elevate-shim

    @jboelter
    jboelter committed Jan 12, 2023
    Configuration menu
    Copy the full SHA
    405e89e View commit details
    Browse the repository at this point in the history

  2. make audit mode happy

    @jboelter
    jboelter committed Jan 12, 2023
    Configuration menu
    Copy the full SHA
    f94b4e9 View commit details
    Browse the repository at this point in the history