Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sure the command palette isn't null #15220

Merged
merged 1 commit into from
Apr 21, 2023
Merged

Make sure the command palette isn't null #15220

merged 1 commit into from
Apr 21, 2023

Conversation

zadjii-msft
Copy link
Member

@zadjii-msft zadjii-msft commented Apr 21, 2023 •
edited by lhecker
Loading

Fixes a crash when pressing a keybinding in the settings tab.

Regressed in #15203

Noted in #14051

@DHowett DHowett enabled auto-merge (squash) April 21, 2023 17:15
lhecker
lhecker approved these changes Apr 21, 2023
View reviewed changes
Copy link
Member

@lhecker lhecker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ugh, thanks for catching this!

@DHowett DHowett merged commit 4788347 into main Apr 21, 2023
@DHowett DHowett deleted the dev/migrie/b/regression-from-15196 branch April 21, 2023 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DHowett DHowett DHowett approved these changes

@lhecker lhecker lhecker approved these changes

@michalnpl michalnpl michalnpl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@zadjii-msft @DHowett @lhecker @michalnpl