Switch to function pointers #15233
Merged
Switch to function pointers #15233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Apparently, `std::function` is bad and we should feel bad. I friggen hate the c++ function pointer syntax, but [I do what I'm told](https://getyarn.io/yarn-clip/85c318d8-f4a7-4da6-ae20-23d7b737e71c) I missed this comment in #15020. Sorry!
carlos-zamora
approved these changes
Apr 25, 2023
Comment on lines
2314
to
2315
| bool (*filter)(const ::Microsoft::Console::VirtualTerminal::DispatchTypes::ScrollMark&), | ||
| til::point_span (*getSpan)(const ::Microsoft::Console::VirtualTerminal::DispatchTypes::ScrollMark&)) |
There was a problem hiding this comment.
Suggested change
| bool (*filter)(const ::Microsoft::Console::VirtualTerminal::DispatchTypes::ScrollMark&), | |
| til::point_span (*getSpan)(const ::Microsoft::Console::VirtualTerminal::DispatchTypes::ScrollMark&)) | |
| bool (*filter)(const DispatchTypes::ScrollMark&), | |
| til::point_span (*getSpan)(const DispatchTypes::ScrollMark&)) |
| @@ -2358,7 +2358,7 @@ namespace winrt::Microsoft::Terminal::Control::implementation | |||
|
|
|||
| bool ControlCore::_clickedOnMark( | |||
| const til::point& pos, | |||
| const std::function<bool(const DispatchTypes::ScrollMark&)>& filter) | |||
| bool (*filter)(const ::Microsoft::Console::VirtualTerminal::DispatchTypes::ScrollMark&)) | |||
There was a problem hiding this comment.
Suggested change
| bool (*filter)(const ::Microsoft::Console::VirtualTerminal::DispatchTypes::ScrollMark&)) | |
| bool (*filter)(const DispatchTypes::ScrollMark&)) |
lhecker
approved these changes
Apr 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apparently,
std::functionis bad and we should feel bad. I friggen hate the c++ function pointer syntax, but I do what I'm toldI missed this comment in #15020. Sorry!