build: pass branding into the nuget variable template #16122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes a cosmetic issue with the version number in the unpackaged builds and NuGet packages.
zadjii-msft
approved these changes
Oct 11, 2023
carlos-zamora
approved these changes
Oct 11, 2023
DHowett
added a commit
that referenced
this pull request
Oct 26, 2023
This fixes a cosmetic issue with the version number in the unpackaged builds and NuGet packages. They were showing up as `-preview`, even when they were stable, because the variable template didn't know about the branding. (cherry picked from commit 544cdd7) Service-Card-Id: 90786432 Service-Version: 1.19
DHowett
added a commit
that referenced
this pull request
Nov 7, 2023
This fixes a cosmetic issue with the version number in the unpackaged builds and NuGet packages. They were showing up as `-preview`, even when they were stable, because the variable template didn't know about the branding. (cherry picked from commit 544cdd7) Service-Card-Id: 90786431 Service-Version: 1.18
DHowett
added a commit
that referenced
this pull request
Nov 7, 2023
This fixes a cosmetic issue with the version number in the unpackaged builds and NuGet packages. They were showing up as `-preview`, even when they were stable, because the variable template didn't know about the branding. (cherry picked from commit 544cdd7) Service-Card-Id: 90786431 Service-Version: 1.18
DHowett
added a commit
that referenced
this pull request
Nov 28, 2023
This fixes a cosmetic issue with the version number in the unpackaged builds and NuGet packages. They were showing up as `-preview`, even when they were stable, because the variable template didn't know about the branding. (cherry picked from commit 544cdd7) Service-Card-Id: 91211923 Service-Version: 1.17
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a cosmetic issue with the version number in the unpackaged builds and NuGet packages.
They were showing up as
-preview, even when they were stable, because the variable template didn't know about the branding.