Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Quick Fix UI and support for custom CommandNotFound OSC #16848
Add Quick Fix UI and support for custom CommandNotFound OSC #16848
Changes from 5 commits
12100c5
c8d13d4
534c2d9
c1e1eab
68ed03d
c2417bb
6a361ef
a2e57b4
cfaa09d
88b64cd
48a36be
d8c8807
8c0d7c6
ec1fbc2
767692c
d4b6904
4e5d07d
27d464c
0f801a9
a545325
755f121
a0aa2d0
1ffbae1
0c5d880
ef6af81
db7f464
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@zadjii-msft is this kinda what you meant by adding the new suggestions to the context? If that's the case, we should rename the context to something else. Maybe
ShellIntegrationContext
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Exactly what I was thinking. My quick recommendations:
WinGetSuggestions
, but insteadQuickFixes
. I'd think these should come through just the same as any other "quick fix" we add to the control (i.e. like a VT-driven one).SuggestionsSource
- that pobably also needs to get added to theJSON_FLAG_MAPPER
inTerminalSettingsSerializationHelpers.h
, asquickFixes
\uEA80
icon in here.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oofda I see the comment about the OEM icon below now. Well, similar idea I guess.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh huh, maybe we do want to give the winget suggestions a different icon. That's actually a really fun idea.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
but also, just adding this here, is that enough to actually let our package know what dll these types are implemented in? Or do we need to do something to make sure the winget package (that presumably implements these) is actually in our package graph?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No clue! This and this comment are gonna be my next step (figuring out how to actually interact with WinGet).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a thought: stage this as two PRs.
winget install foo
, don't actually do the package lookup.foo
.