#1536 - Feature Request - Duplicate tab

[dnagl]

Added keybinding option to duplicate focused tab

Summary of the Pull Request

Added necessary delcarations and implmentations to provide a new keybinding for duplicating the focused tab.

References

PR Checklist

• Closes Feature Request - Duplicate tab (Basic) #1536
• CLA signed. If not, go over here and sign the CLA
• Tests added/passed N/A
• Requires documentation to be updated
• I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: Feature Request - Duplicate tab (Basic) #1536

Detailed Description of the Pull Request / Additional comments

As discussed in this issue, a simple implementation for duplicating the focused tab was made by me.
I added the needed declarations for the new keybinding and added a method to duplicate the focused tab in App.cpp.

Validation Steps Performed

• Add keybinding element to profiles.json
  • "command" : "duplicateTab"
  • "keys": [ "ctrl+shift+d" ]
• Open Terminal
• Verify other features and functionalities work as usual without unexpected behaviour
• Use configured keybinding to validate the duplication of the focused tab

[carlos-zamora]

Please run the Code Formatter located in tools\OpenConsole.psm1

Other than that, pretty straightforward. Thanks!

[JushBJJ]

Awesome feature that is needed!

[dnagl]

@JushBJJ I also think that this is a great feature in this project. This is one of multiple steps. in #1535 there was a discussion about three different stages of this feature which I hope we can see them in the first release.

[miniksa]

fix tabs/spacing issues and I think its good

[dnagl]

@miniksa You were right. I did not set this option in Visual Studio in the first place. The changes are made.
Thanks for the review ;)

[zadjii-msft]

Looks solid to me.

[miniksa]

I'm good with this, but I'm going to try to see why the line Carlos marked is a diff despite looking exactly the same before I hit the merge button.

[ghost]

🎉Windows Terminal Preview v0.3.2142.0 has been released which incorporates this pull request.:tada:

Handy links:

• Release Notes
• Store Download