Add descriptions to commands (namely, snippets) #17376
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
commit 8b19458 Author: Mike Griese <migrie@microsoft.com> Date: Fri Feb 16 05:49:37 2024 -0600 I can't quite get bottom-up mode to work right commit d77e3d5 Author: Mike Griese <migrie@microsoft.com> Date: Thu Feb 15 16:21:00 2024 -0600 stash temporarily commit 7b76ef8 Author: Mike Griese <migrie@microsoft.com> Date: Thu Feb 15 15:40:14 2024 -0600 yea this looks better commit 21ce4be Author: Mike Griese <migrie@microsoft.com> Date: Thu Feb 15 14:04:04 2024 -0600 out of body experience commit ec36139 Author: Mike Griese <migrie@microsoft.com> Date: Thu Feb 15 13:48:06 2024 -0600 an idea: just put the tooltips in the body?
|
Gifs: bottom-up suggestion palette |
zadjii-msft
commented
Jun 5, 2024
| @@ -103,23 +103,10 @@ | |||
| </ResourceDictionary> | |||
| </UserControl.Resources> | |||
|
|
|||
| <Grid> | |||
There was a problem hiding this comment.
guess what? we basically weren't using this Grid for anything. There was only ever _backdrop in it, taking up the whole thing.
This was a side-effect of command palette copypasta
lhecker
reviewed
Jun 10, 2024
lhecker
approved these changes
Jun 11, 2024
PankajBhojwani
approved these changes
Jun 12, 2024
DHowett
reviewed
Jun 12, 2024
|
|
||
| // Now fill up the "subtitle" part of the "tooltip" with the actual | ||
| // description itself. | ||
| const auto& inlines{ _descriptionComment().Inlines() }; |
There was a problem hiding this comment.
Suggested change
| const auto& inlines{ _descriptionComment().Inlines() }; | |
| const auto inlines{ _descriptionComment().Inlines() }; |
this is a bad habit, we should not perpetuate it
DHowett
reviewed
Jun 12, 2024
| void SuggestionsControl::_recalculateTopMargin() | ||
| { | ||
| auto currentMargin = Margin(); | ||
| // Call Measure() on the descriptions backdrop, so that it gets it's new |
There was a problem hiding this comment.
Suggested change
| // Call Measure() on the descriptions backdrop, so that it gets it's new | |
| // Call Measure() on the descriptions backdrop, so that it gets its new |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a
"description"property to actions. Notably, the shell completion protocol (#3121) will now also populate that.The suggestions UI can then use those descriptions to display an additional tooltip with that information.
TeachingTip was kinda an abject disaster last time I tried this, so this isn't a TeachingTip. It's literally a text block.
xlinks: